In riscv_const.py, the following constants are undefined in capstone:
|
RISCV_GRP_ISRVA = 135 |
|
RISCV_GRP_ISRVC = 136 |
|
RISCV_GRP_ISRVD = 137 |
|
RISCV_GRP_ISRVCD = 138 |
|
RISCV_GRP_ISRVF = 139 |
|
RISCV_GRP_ISRV32C = 140 |
|
RISCV_GRP_ISRV32CF = 141 |
|
RISCV_GRP_ISRVM = 142 |
|
RISCV_GRP_ISRV64A = 143 |
|
RISCV_GRP_ISRV64C = 144 |
|
RISCV_GRP_ISRV64D = 145 |
|
RISCV_GRP_ISRV64F = 146 |
|
RISCV_GRP_ISRV64M = 147 |
Check the corresponding constants in riscv.h:
|
/* |
|
RISCV_GRP_ISRVA, |
|
RISCV_GRP_ISRVC, |
|
RISCV_GRP_ISRVD, |
|
RISCV_GRP_ISRVCD, |
|
RISCV_GRP_ISRVF, |
|
RISCV_GRP_ISRV32C, |
|
RISCV_GRP_ISRV32CF, |
|
RISCV_GRP_ISRVM, |
|
RISCV_GRP_ISRV64A, |
|
RISCV_GRP_ISRV64C, |
|
RISCV_GRP_ISRV64D, |
|
RISCV_GRP_ISRV64F, |
|
RISCV_GRP_ISRV64M, |
|
*/ |
It seems those constants in riscv_const.py should be commented.
Should I raise a PR to do it?
In
riscv_const.py, the following constants are undefined in capstone:capstone/bindings/python/capstone/riscv_const.py
Lines 442 to 454 in 6461ed0
Check the corresponding constants in
riscv.h:capstone/include/capstone/riscv.h
Lines 512 to 526 in 6461ed0
It seems those constants in
riscv_const.pyshould be commented.Should I raise a PR to do it?