moved file.close() to the end of the loop as opposed to deferring the call. This is because deferring the call would close all the files after the function scope is finished which results in an accumelated number of open files. This causes the utility to crash when too many files are being uploaded all at once. (#22)

peter-emil · web-flow · commit 71495811b644 · 2021-10-21T01:19:09.000+02:00
Co-authored-by: Peter Emil &lt;peter@buffer.com&gt;
diff --git a/main.go b/main.go
@@ -26,7 +26,7 @@ import (
 )
 
 // VERSION is the current version
-const VERSION = "0.2.1"
+const VERSION = "0.4.0"
 
 var defaultS3Bucket = "static.buffer.com"
 var uploader *s3manager.Uploader
@@ -190,7 +190,6 @@ func VersionAndUploadFiles(
 		if err != nil {
 			return fileVersions, err
 		}
-		defer file.Close()
 
 		uploadFilename, err := GetUploadFilename(file, filename, skipVersioning)
 		if err != nil {
@@ -214,6 +213,7 @@ func VersionAndUploadFiles(
 		}
 
 		fileVersions[filename] = fileURL
+		file.Close()
 	}
 
 	return fileVersions, nil

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ import (`
`26`	`26`	`)`
`27`	`27`
`28`	`28`	`// VERSION is the current version`
`29`		`-const VERSION = "0.2.1"`
	`29`	`+const VERSION = "0.4.0"`
`30`	`30`
`31`	`31`	`var defaultS3Bucket = "static.buffer.com"`
`32`	`32`	`var uploader *s3manager.Uploader`
`@@ -190,7 +190,6 @@ func VersionAndUploadFiles(`
`190`	`190`	`if err != nil {`
`191`	`191`	`return fileVersions, err`
`192`	`192`	`}`
`193`		`- defer file.Close()`
`194`	`193`
`195`	`194`	`uploadFilename, err := GetUploadFilename(file, filename, skipVersioning)`
`196`	`195`	`if err != nil {`
`@@ -214,6 +213,7 @@ func VersionAndUploadFiles(`
`214`	`213`	`}`
`215`	`214`
`216`	`215`	`fileVersions[filename] = fileURL`
	`216`	`+ file.Close()`
`217`	`217`	`}`
`218`	`218`
`219`	`219`	`return fileVersions, nil`