Skip to content

ci(android): disable on-device tests (Swift 6.4 ELF) - #138

Merged
leogdion merged 1 commit into
mainfrom
ci/android-run-tests-false
Jul 23, 2026
Merged

leogdion merged 1 commit into
mainfrom
ci/android-run-tests-false

Conversation

@leogdion

@leogdion leogdion commented Jul 23, 2026 •

Copy link
Copy Markdown
Member

Summary

Why

Swift 6.3 × API 28/34 pass with tests on; Swift 6.4 snapshot fails with ./SyndiKitTests-test-runner: not executable: 64-bit ELF file on the emulator (e.g. main run). This is blocking the Wave 0 main CI gate.

Follow-up: #137

Test plan

  • Android matrix jobs succeed (build-only) on this PR / after merge to main
  • Confirm 6.3 and 6.4 × API 28/34 all green without emulator test step

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Updated Android continuous integration checks to build Swift 6.4 nightly configurations without attempting unavailable emulator test execution.
    • Added documentation explaining why Android emulator tests remain disabled until the underlying execution issue is resolved.

Swift 6.4 nightly Android legs fail launching the test runner on the
emulator ("not executable: 64-bit ELF file"); 6.3 passes. Keep the
matrix as build-only and track re-enable in #137.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 93cbc8c2-5be4-4fce-a904-1c2f522b0876

📥 Commits

Reviewing files that changed from the base of the PR and between f285c0c and f29bc95.

📒 Files selected for processing (1)
  • .github/workflows/SyndiKit.yml

📝 Walkthrough

Walkthrough

The Android CI workflow now runs Swift 6.4 nightly Android legs as build-only jobs, with comments documenting the emulator execution failure and the condition for re-enabling tests.

Changes

Android nightly CI

Layer / File(s) Summary
Disable Android emulator tests
.github/workflows/SyndiKit.yml
Documents the Swift 6.4 emulator failure and sets android-run-tests to false while preserving Android builds.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related issues

  • SyndiKit issue 137 — Directly tracks the workaround implemented by disabling Android test execution for Swift 6.4 nightly builds.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: Android CI on-device tests are disabled due to the Swift 6.4 ELF issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/android-run-tests-false

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
.github/workflows/SyndiKit.yml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@claude

claude Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review

Small, well-scoped CI change — disables on-device Android test execution (build stays, tests skip) to unblock the main gate, with a clear comment and a tracking issue (#137) for the real fix. A few notes:

Code quality

  • The change follows the file's existing convention of leaving a comment block above a job explaining a CI workaround (see the full-matrix tier comment right above it) — good consistency.
  • android-run-tests: false is applied to the whole build-android matrix (both Swift 6.3/6.4 × API 28/34), not just the failing 6.4 legs. Per Android: Swift 6.4 nightly test runner not executable on emulator (64-bit ELF) #137 (and this PR's own description), 6.3 currently passes with tests on, so this trades away real on-device coverage for 6.3 that wasn't broken. I see Android: Swift 6.4 nightly test runner not executable on emulator (64-bit ELF) #137's checklist already flags "re-enable android-run-tests: true (at least for 6.4 rows, or the whole matrix)" as a known follow-up, so this looks like a deliberate blanket rollback for simplicity rather than an oversight — just flagging it in case scoping it now (e.g. adding a run-tests field per matrix.swift entry the way sdk-url/sdk-id are already scoped) is preferable to losing 6.3 coverage in the meantime.

Bugs/correctness

  • None in the workflow YAML itself — the diff is syntactically consistent with the surrounding with: block and matrix structure.

Test coverage impact

Performance

  • Should modestly speed up the Android matrix (no emulator boot + test run), which also reduces the disk-space pressure free-disk-space is working around.

Security

  • No concerns; workflow-only change, no new permissions, secrets, or third-party actions introduced.

Overall this looks like the right stop-gap given #137. The only thing worth considering is whether to scope android-run-tests to just the 6.4 row instead of the whole matrix, to keep 6.3 on-device coverage in the interim — but that's a minor judgment call, not a blocker.

@codecov

codecov Bot commented Jul 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.07%. Comparing base (f285c0c) to head (f29bc95).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   79.07%   79.07%           
=======================================
  Files          74       74           
  Lines        1553     1553           
=======================================
  Hits         1228     1228           
  Misses        325      325           
Flag Coverage Δ
5.10 66.06% <ø> (ø)
6.0 78.30% <ø> (ø)
6.1 78.30% <ø> (ø)
6.2 78.30% <ø> (ø)
6.3 78.30% <ø> (ø)
ios18.5 78.30% <ø> (ø)
ios26.5 78.30% <ø> (ø)
jammy 79.07% <ø> (ø)
macos 78.30% <ø> (ø)
macos-15 78.30% <ø> (ø)
macos-26 78.30% <ø> (ø)
noble 79.07% <ø> (ø)
spm 79.07% <ø> (ø)
tvos18.5 78.30% <ø> (ø)
tvos26.5 78.30% <ø> (ø)
visionos2.5 78.30% <ø> (ø)
visionos26.5 78.30% <ø> (ø)
watchos11.5 78.30% <ø> (ø)
watchos26.5 78.30% <ø> (ø)
xcode-27 78.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leogdion
leogdion merged commit 0b55cb0 into main Jul 23, 2026
48 checks passed
@leogdion
leogdion deleted the ci/android-run-tests-false branch July 26, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant