ci(android): disable on-device tests (Swift 6.4 ELF) - #138
Conversation
Swift 6.4 nightly Android legs fail launching the test runner on the
emulator ("not executable: 64-bit ELF file"); 6.3 passes. Keep the
matrix as build-only and track re-enable in #137.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Android CI workflow now runs Swift 6.4 nightly Android legs as build-only jobs, with comments documenting the emulator execution failure and the condition for re-enabling tests. ChangesAndroid nightly CI
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8).github/workflows/SyndiKit.ymlTraceback (most recent call last): Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ReviewSmall, well-scoped CI change — disables on-device Android test execution (build stays, tests skip) to unblock the Code quality
Bugs/correctness
Test coverage impact
Performance
Security
Overall this looks like the right stop-gap given #137. The only thing worth considering is whether to scope |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 79.07% 79.07%
=======================================
Files 74 74
Lines 1553 1553
=======================================
Hits 1228 1228
Misses 325 325
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
android-run-tests: falseon the Android matrix so Swift 6.4 nightly legs stay green as build-only.Why
Swift 6.3 × API 28/34 pass with tests on; Swift 6.4 snapshot fails with
./SyndiKitTests-test-runner: not executable: 64-bit ELF fileon the emulator (e.g. main run). This is blocking the Wave 0mainCI gate.Follow-up: #137
Test plan
mainMade with Cursor
Summary by CodeRabbit