Skip to content

Conversation

@ofekashery
Copy link
Contributor

@ofekashery ofekashery commented Apr 8, 2025

The __import__ function is an internal and intended for use by the Python interpreter only - not for general use.

It’s safer to use importlib.import_module(), which removes the need for manual handling and reduces potential errors.

@ofekashery
Copy link
Contributor Author

@nateprewitt

@nateprewitt nateprewitt closed this Dec 5, 2025
@nateprewitt nateprewitt reopened this Dec 5, 2025
@nateprewitt
Copy link
Contributor

Thanks for the PR, @ofekashery! I've restarted a fresh run of CI to make sure things work as expected. Assuming that comes back working, I'll do some final validation and we can look at merging this.

@nateprewitt nateprewitt self-requested a review December 5, 2025 23:29
@nateprewitt
Copy link
Contributor

nateprewitt commented Dec 5, 2025

Looks like there was a leftover sys import that wasn't cleaned up which linting is flagging. I pushed up a small commit to address that. Once the build finishes, we should be ready to merge.

@nateprewitt nateprewitt merged commit b37b743 into boto:develop Dec 6, 2025
39 checks passed
@nateprewitt
Copy link
Contributor

Thanks again, @ofekashery!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants