Skip to content

Conversation

@trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Dec 5, 2025

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/PM-11866

๐Ÿ“” Objective

We are actively discouraging the use of ActiveUserState<T> - see https://github.com/bitwarden/clients/tree/main/libs/state#should-i-use-activeuserstate.

This PR marks it as obsolete so that it will not accidentally be introduced for new state definitions.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 4c574f4f-ba0c-4840-a857-24da29ae4223

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โœ… Project coverage is 41.70%. Comparing base (701ecb7) to head (a91bdd4).
โš ๏ธ Report is 6 commits behind head on main.
โœ… All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17844      +/-   ##
==========================================
- Coverage   41.71%   41.70%   -0.01%     
==========================================
  Files        3571     3571              
  Lines      103768   103768              
  Branches    15613    15613              
==========================================
- Hits        43288    43281       -7     
- Misses      58645    58652       +7     
  Partials     1835     1835              

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants