Skip to content

PM-45252: feat: Update the Premium dialog copy and preserve the plan badge state on soft-logout - #7607

Open
david-livefront wants to merge 1 commit into
mainfrom
PM-45252-premium-dialog-update
Open

david-livefront wants to merge 1 commit into
mainfrom
PM-45252-premium-dialog-update

Conversation

@david-livefront

@david-livefront david-livefront commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-45252

📔 Objective

This PR fixes some over sites on the update Premium Dialog and Badge flow. The Dialogs copy has be switched to match expected behavior and the badge state is preserved across a soft-logout.

@david-livefront
david-livefront requested a review from a team as a code owner November 11, 2026 21:51
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

This PR swaps which label the PremiumRequiredDialog confirm button shows depending on isInAppUpgradeAvailable. It also keeps the per-user plan badge flag through a soft logout. The soft-logout change matches the existing save-and-restore pattern in UserLogoutManagerImpl, and its unit tests cover both the soft-logout and full-logout paths. The label swap was not carried into the app-module Compose screen tests, which still expect the old button text. Those tests will fail.

Code Review Details
  • ⚠️ : The button label swap breaks about 11 screen tests that still expect the old "Upgrade to Premium" / "Explore Premium" mapping
    • ui/src/main/kotlin/com/bitwarden/ui/platform/components/dialog/PremiumRequiredDialog.kt:27

@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.85%. Comparing base (e1f5dd4) to head (6a85c83).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7607   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files         898      898           
  Lines       65211    65211           
  Branches     9378     9378           
=======================================
  Hits        56640    56640           
  Misses       5098     5098           
  Partials     3473     3473           
Flag Coverage Δ
app-data 19.00% <100.00%> (ø)
app-ui-auth-tools 18.75% <0.00%> (ø)
app-ui-platform 16.02% <0.00%> (ø)
app-ui-vault 27.02% <0.00%> (ø)
authenticator 6.06% <0.00%> (ø)
lib-core-network-bridge 4.16% <0.00%> (ø)
lib-data-ui 1.33% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-livefront
david-livefront force-pushed the PM-45252-premium-dialog-update branch from 1434da3 to 6a85c83 Compare November 11, 2026 22:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant