testdata: remove unused output_inline.go

Author: bhandras

TODO.md

@@ -0,0 +1,248 @@
+# Refactor TODOs (Function Length & Complexity)
+
+This list prioritizes high-impact function length and nesting reductions while
+preserving behavior. Do not touch `testdata/**`.
+
+Generated from `golangci-lint run --enable-only funlen,nestif` analysis.
+
+## Agent Prompt (Refactor Workflow)
+
+Use this process when refactoring for length/complexity reduction:
+
+- Work from top priority to lower in this file.
+- Refactor one function at a time using helper extraction and early returns.
+- After each function refactor, run `make unit`.
+- Do not edit `testdata/**` or golden outputs.
+- If a behavior change is needed, add targeted tests (outside `testdata/**`).
+- Before committing: run `make fmt`, verify `git status` only has intended
+  changes, then commit.
+
+Commit message format:
+
+- Subject: `package: short desc` (<= 64 chars), use `multi:` if needed.
+- Body: wrap at 72 chars.
+
+Example:
+
+```
+multi: reduce function length in call formatting
+Extract helpers to reduce function length in call packing and signature
+handling without behavior changes.
+```
+
+## Output Diff Check (Behavior Drift)
+
+Use `tools/plan_diff.sh` to compare actual formatted output against a baseline.
+The script automatically rebuilds llformat before each run.
+
+Examples:
+
+- Create baseline from ~/work/lnd-origin:
+  `tools/plan_diff.sh --baseline /tmp/format-baseline --update ~/work/lnd-origin`
+- Compare current output against baseline:
+  `tools/plan_diff.sh --baseline /tmp/format-baseline ~/work/lnd-origin`
+- Skip rebuild (when testing quickly):
+  `tools/plan_diff.sh --skip-build --baseline /tmp/format-baseline ~/work/lnd-origin`
+
+---
+
+# Deep Nesting Issues (nestif complexity >= 4)
+
+These blocks have nesting deeper than 3 levels (if-in-if, if-in-for, etc.).
+Use early returns, helper extraction, or state machines to flatten.
+
+## N0 (Critical: complexity >= 20)
+
+- `formatter/func_sig_formatter.go:1205` in `breakSignature` (complexity: 108!)
+  - The `if returns != ""` block has extreme nesting depth.
+  - Extract: `formatReturnsBlock`, `formatCanonicalReturns`,
+    `formatLegacyReturns`, `handleMultipleReturns`.
+- `formatter/compact_call_formatter.go:1479` in `formatCallPackedMultiLineNext`
+  (complexity: 24)
+  - The `if llast.IsCallExpr(a)` block for nested call handling.
+  - Extract: `handleNestedCallArg`, `formatCallInArg`.
+- `dsl/action.go:3659` in `formatSignatureSimple` (complexity: 23)
+  - The `if hasReturns` block for return formatting.
+  - Extract: `formatSimpleReturnsBlock`.
+- `dsl/action.go:4090` in `formatMethodSimple` (complexity: 23)
+  - The `if hasReturns` block (duplicate logic with above).
+  - Extract: `formatMethodReturnsBlock`.
+- `formatter/func_sig_formatter.go:1672` in `formatFuncTypeParam` (complexity: 22)
+  - The width-check block for function type parameters.
+  - Extract: `breakFuncTypeParam`, `formatFuncTypeMultiline`.
+
+## N1 (High: complexity 10-19)
+
+- `formatter/compact_call_formatter.go:1928` in `formatCallGreedyWithOptions`
+  (complexity: 17)
+  - The `if i > 0` block for argument processing.
+  - Extract: `processGreedyArg`, `handleGreedyLineBreak`.
+- `formatter/func_sig_formatter.go:1127` in `breakSignature` (complexity: 15)
+  - The `if needsFuncBreak` block.
+  - Extract: `formatFuncTypeParamBreak`.
+- `formatter/func_sig_formatter.go:826` in `formatSignature` (complexity: 14)
+  - The `if inlineBodyFound` block for inline function bodies.
+  - Extract: `handleInlineBody`, `formatInlineReturn`.
+- `formatter/func_sig_formatter.go:2168` in `formatInterfaceReturns`
+  (complexity: 10)
+  - The `if strings.HasPrefix(returns, "(")` block.
+  - Extract: `formatParenthesizedReturns`.
+- `formatter/compact_call_formatter.go:2317` in `formatCallGreedyWithOptions`
+  (complexity: 10)
+  - The `if cut <= 0` block for line cutting.
+  - Extract: `handleGreedyCut`.
+
+## N2 (Medium: complexity 4-9)
+
+- `dsl/action.go:3618` in `formatSignatureSimple` (complexity: 6)
+  - `if needMultiParams` block.
+- `dsl/action.go:4049` in `formatMethodSimple` (complexity: 6)
+  - `if needMultiParams` block (duplicate).
+- `formatter/compact_call_formatter.go:2043` (complexity: 6)
+  - `if a.kind == argExpr` block.
+- `formatter/compact_call_formatter.go:2282` (complexity: 6)
+  - `if cut <= 0 && capCols <= 0` block.
+- `formatter/func_sig_formatter.go:265` (complexity: 5)
+  - `if strings.Contains(signature, "\n")` block.
+- `formatter/func_sig_formatter.go:970` (complexity: 5)
+  - `if strings.HasPrefix(afterParams, "(")` block.
+- `dsl/action.go:3953` (complexity: 4)
+- `dsl/action.go:4491` (complexity: 4)
+- `dsl/condition.go:1236` (complexity: 4)
+- `formatter/compact_call_formatter.go:2145` (complexity: 4)
+- `formatter/compact_call_formatter.go:3000` (complexity: 4)
+- `formatter/func_sig_formatter.go:415` (complexity: 4)
+- `formatter/func_sig_formatter.go:932` (complexity: 4)
+- `internal/compat/comment_formatter.go:501` (complexity: 4)
+
+---
+
+# Function Length Issues (funlen)
+
+## Excluded Files (Intentionally Long)
+
+The following files contain declarative rule configurations that are naturally
+long. These are readable as-is and should NOT be refactored for funlen:
+
+- `dsl/rules.go` - Rule definitions are declarative data; splitting would
+  reduce readability without improving maintainability.
+
+## P0 (Critical: >100 lines or >80 statements over limit)
+
+These are the largest functions and most urgent to split.
+- `formatter/compact_call_formatter.go:1872: formatCallGreedyWithOptions`
+  (170 stmts, limit 40)
+  - Extract: `greedyArgState`, `appendGreedyArg`, `emitGreedyLine`,
+    `handleGreedyBreak`.
+- `formatter/func_sig_formatter.go:916: breakSignature` (120 stmts, limit 40)
+  - Extract: `formatParams`, `formatReturns`, `buildSignature`,
+    `handleMultilineReturn`.
+- `tools/fmt_repo/main.go:38: main` (111 lines, limit 60)
+  - Extract: `parseFlags`, `collectFiles`, `processFiles`, `reportResults`.
+- `formatter/dsl_bundles_next.go:176: dslRulesForSignatures` (108 lines,
+  limit 60)
+  - Extract: `funcDeclSignatureRules`, `funcLitSignatureRules`,
+    `interfaceMethodRules`.
+- `formatter/compact_call_formatter.go:1352: formatCallPackedMultiLineNext`
+  (108 stmts, limit 40)
+  - Extract: `packArgsNext`, `emitPackedNextLine`, `handleStringLitNext`.
+
+## P1 (High: 30-100 lines over limit)
+
+- `dsl/action.go:1165: BreakCallArgsLayoutAction.Execute` (95 lines, limit 60)
+  - Extract: `resolveCallArgsTarget`, `buildCallArgsLayout`,
+    `applyCallArgsEdits`.
+- `dsl/action.go:4199: BlankLinesBatchAction.Execute` (92 lines, limit 60)
+  - Extract: `collectBlankLineEdits`, `applyBlankLineEdits`.
+- `formatter/pipeline.go:96: NewPipeline` (91 lines, limit 60)
+  - Extract: `applyPipelineDefaults`, `buildStages`, `configureDSLOptions`.
+- `formatter/compact_call_formatter.go:794: formatCallPackedMultiLine`
+  (90 stmts, limit 40)
+  - Extract: `initPackedCallState`, `packArg`, `emitPackedLine`.
+- `dsl/layout/render.go:167: fitsAt` (90 lines, limit 60)
+  - Extract: `fitsAtDoc`, `fitsAtBreak`, `fitsAtGroup`.
+- `formatter/func_sig_formatter.go:1729: formatFuncTypeParam` (88 stmts,
+  limit 40)
+  - Extract: `parseFuncType`, `formatFuncTypeParams`, `formatFuncTypeReturns`.
+- `dsl/expr_doc.go:467: methodChainSegmentDoc` (84 lines, limit 60)
+  - Extract: `segmentCallDoc`, `segmentSelectorDoc`, `segmentBaseDoc`.
+- `dsl/rules.go:887: BlankLineRulesWithOptions` (82 lines, limit 60)
+  - Extract: `returnBlankRules`, `caseClauseBlankRules`, `ifErrBlankRules`.
+- `dsl/action.go:3881: BreakInterfaceMethodAction.Execute` (82 lines, limit 60)
+  - Extract: `resolveInterfaceMethod`, `formatInterfaceMethod`,
+    `maybeInsertBlankAfterMethod`.
+- `cmd/llformat/main.go:29: run` (82 lines, limit 60)
+  - Extract: `parseArgs`, `runFormat`, `runPrintPlan`.
+- `dsl/pattern.go:91: matchType` (81 stmts, limit 40)
+  - Use a map[string]func(ast.Node)bool or type switch consolidation.
+
+## P2 (Medium: 10-30 lines over limit)
+
+- `cmd/llformat/main.go:223: runPrintPlan` (77 lines, limit 60)
+  - Extract: `buildPlanConfig`, `printPlanStages`.
+- `dsl/expr_doc.go:1197: sliceExprDoc` (74 lines, limit 60)
+  - Extract: `buildSliceDocs`, `maybeStructuredSliceDocs`.
+- `dsl/expr_doc.go:576: genericCallDoc` (73 lines, limit 60)
+  - Extract: `buildCallDocs`, `formatCallLayout`.
+- `formatter/config_validation.go:16: ValidatePipelineConfig` (70 lines,
+  limit 60)
+  - Extract: `validateStyleOptions`, `validateDSLOptions`.
+- `dsl/rules.go:1298: PackedMultiLineOnlyRulesWithOptions` (69 lines, limit 60)
+  - Extract: `packedOnlyCallRules`, `packedOnlyStringRules`.
+- `formatter/func_sig_formatter.go:2161: formatInterfaceReturns` (68 lines,
+  limit 60)
+  - Extract: `formatSingleReturn`, `formatMultiReturn`.
+- `dsl/action.go:2893: BreakFuncSignatureAction.Execute` (68 lines, limit 60)
+  - Extract: `resolveFuncSigTarget`, `formatFuncSignature`,
+    `shouldInsertBlankAfterSig`.
+- `formatter/legacy_call_selector.go:67: legacyCallSpansFromAST` (66 lines,
+  limit 60)
+  - Extract: `collectCallSpans`, `filterLegacySpans`.
+- `formatter/func_sig_formatter.go:1557: splitFuncParamList` (64 lines,
+  limit 60)
+  - Extract: `scanParamBoundaries`, `splitAtBoundaries`.
+- `dsl/rules.go:2119: MethodChainRules` (64 lines, limit 60)
+  - Extract: `chainCallRule`, `chainSelectorRule`.
+
+## P3 (Low: <10 lines over limit or slightly over statement limit)
+
+- `formatter/func_sig_formatter.go:2290: canonicalizeInterfaceMethodParenReturnList`
+  (63 lines, limit 60)
+- `internal/compat/comment_formatter.go:540: hoistInlineComments` (62 lines,
+  limit 60)
+  - Extract: `scanLineForInline`, `rewriteInlineComment`.
+- `internal/compat/comment_formatter.go:375: reflowBlockComment` (61 stmts,
+  limit 40)
+  - Extract: `blockCommentPrefix`, `reflowBlockWords`.
+- `dsl/action.go:2695: BreakFuncLitSignatureAction.Execute` (59 stmts, limit 40)
+  - Extract: `resolveFuncLit`, `formatFuncLitSignature`.
+- `dsl/action.go:3565: formatSignatureSimple` (55 stmts, limit 40)
+  - Extract: `formatSimpleParams`, `formatSimpleReturns`.
+- `internal/compat/comment_formatter.go:271: reflowLineCommentBlock` (54 stmts,
+  limit 40)
+  - Extract: `lineCommentPrefix`, `reflowLineWords`.
+- `formatter/func_sig_formatter.go:718: formatSignature` (51 stmts, limit 40)
+  - Extract: `splitSignatureLines`, `formatSignatureParts`.
+- `formatter/compact_call_formatter.go:1716: buildSplitQuotedWithOptions`
+  (51 stmts, limit 40)
+  - Extract: `splitQuotedLine`, `emitQuotedSegment`.
+- `dsl/action.go:3987: formatMethodSimple` (51 stmts, limit 40)
+  - Extract: `formatMethodParams`, `formatMethodReturns`.
+- `dsl/expr_doc.go:696: compositeLitDoc` (45 stmts, limit 40)
+  - Extract: `buildCompositeLitDocs`, `formatCompositeLitLayout`.
+- `scanner/split.go:19: splitAtDepthZero` (45 stmts, limit 40)
+  - Extract: `trackBracketDepth`, `splitAtZero`.
+- `dsl/action.go:4481: BreakMethodChainAction.Execute` (44 stmts, limit 40)
+  - Extract: `resolveChainTarget`, `formatChainBreaks`.
+- `dsl/engine.go:79: Format` (44 stmts, limit 40)
+  - Extract: `prepareContext`, `runIterations`, `finalizeFormat`.
+- `dsl/action.go:3291: formatSignatureCompat` (43 stmts, limit 40)
+  - Extract: `formatCompatParams`, `formatCompatReturns`.
+- `formatter/dsl_bundles_next.go:102: dslRulesForMultiLineCalls` (41 stmts,
+  limit 40)
+- `dsl/func_lit_expand_action.go:19: ExpandFuncLitBodyAction.Execute`
+  (41 stmts, limit 40)
+- `formatter/func_sig_formatter.go:536: collapseSignatureWhitespace`
+  (41 stmts, limit 40)
+- `dsl/layout/render.go:32: RenderAt` (46 stmts, limit 40)
+  - Extract: `renderDoc`, `renderBreak`, `renderGroup`.