-
Notifications
You must be signed in to change notification settings - Fork 259
chore(metrics): Replace cosmossdk.io/telemetry with prometheus/client_golang #2966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fridrik01
wants to merge
5
commits into
blobreactor
Choose a base branch
from
blobreactor-prometheus2
base: blobreactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54ff194 to
c7a65d3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## blobreactor #2966 +/- ##
===============================================
+ Coverage 63.24% 64.15% +0.91%
===============================================
Files 367 371 +4
Lines 18014 18597 +583
===============================================
+ Hits 11393 11931 +538
- Misses 5713 5759 +46
+ Partials 908 907 -1
🚀 New features to boost your workflow:
|
0a936e8 to
784b633
Compare
784b633 to
78c4ed4
Compare
d197b37 to
2dac820
Compare
4c886ad to
9a5c6eb
Compare
2dac820 to
4536507
Compare
9a5c6eb to
8666900
Compare
b62bf9f to
0ef6906
Compare
…ency Remove use of cosmossdk.io/telemetry package which relies on go-metrics and replace it with direct use of prometheus/client_golang. This aligns with how CometBFT handles metrics and brings several benefits: eliminates race conditions from go-metrics, avoids questionable maintenance of upstream repo, removes problematic metric retention, and significantly simplifies the metrics codebase. All beacon-kit services now use prometheus client directly through a unified metrics.Factory interface. Additionally, replace cosmossdk.io/store/metrics imports with a custom storage.NoOpStoreMetrics implementation to avoid pulling in the telemetry wrapper. While go-metrics remains as a transitive dependency through cosmossdk.io/store/types, it is no longer used at runtime.
99565e2 to
5fe4aab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
cosmossdk.io/telemetry(which depends ongo-metrics) and replaces it with direct usage of the Prometheus client library (prometheus/client_golang). This alignsbeacon-kitwithCometBFT’s metrics approach and brings several key improvements:go-metrics.All components now expose metrics via a common
metrics.Factoryinterface, which standardizes registration, labeling, and naming conventions.Additionally:
cosmossdk.io/store/metricsimports with a lightweightstorage.NoOpStoreMetricsimplementation to remove telemetry dependencies.go-metricsremains a transitive dependency throughcosmossdk.io/store/types, it is no longer used at runtime.NOTE: Since this is a large PR I tried to make it backwards compatible as much as possible, even if it went against prometheus conventions. Future PRs could address these items separately:
promlinter(which now correctly identifies naming issues that were previously undetected)