BUG: Host able to submit a second renewal app for the same registration

[pasherwo]

Description: 
A host was renewed their registration in February 2026. They received a NOC on June 9, 2026. On June 18, 2026, we received a second renewal application and the host's registration was extended another year. Seen in production with registration #: H086992528. The 2nd renewal was started and submitted today.

What is the expected behaviour?: 
Host should not be able to start and submit a renewal application outside of their renewal window

Background:
A similar issue was previously fixed in an earlier release via ticket https://app.zenhub.com/workspaces/strr-65b2a7146835aa0cdf315b79/issues/gh/bcgov/strr/1575

Who is affected?: 
Registrants, Examiners, CITZ

To recreate:
I have been unable to recreate. I thought it could be due to the new host dashboard, maybe the new renewal button was persistent, but it only shows up when the registration is expiring soon or expired. Can we get help to investigate how this happened?

[pasherwo]

More examples have come in. They are: H647113371, H615184545, H935239406, and H346512732 (2nd renewal app started Jun18 but not paid for)

[jimmypalelil]

@pasherwo for all the registrations listed above, there were 2 draft renewals created on the same day within seconds or minutes of each other.

One of the renewals for these regs was submitted in June while the other was submitted within days of the draft creation.

At the time of the second renewal the registration was likely already in a state where the expiry was already extended by 1 year, so the second renwal application could be submitted w/o any restrictions.

[pasherwo]

@jimmypalelil , so if I'm correct in my thinking, submitting 2 draft renewals originally was the problem that started this. However, because of the fix you did to prevent this in the last release, this can no longer happen. Maybe we need to come up with a plan to delete these draft renewals where another renewal was successfully submitted? Can we build the logic into the successful submission of a renewal (all existing draft renewals for the same period are deleted?)

[jimmypalelil]

@pasherwo
Correct. To deal with the existing draft applications, it would be ideal to implement constraints in the backend for when a renewal application can be submitted.

[pasherwo]

Sent to housing:
FYI, we have figured out what is causing the duplicate renewal applications for the same period that we have seen:

• The problem comes from the fact that hosts were able to have 2 draft renewals started (this is no longer possible since a bug fix last release)
• One of the draft renewals was submitted early in 2026 (most in January for some reason)
• The second stayed on the hosts dashboard as a draft.
• A NOC was created for each of the hosts we have seen this happen to
• Somehow, when the host went to check their dashboard, they saw the draft renewal that still existed and completed it, causing the 2nd renewal application and pushing the expiry date out another year.

So, the original problem of having 2 draft renewals will not occur anymore, but we do not know how many other hosts may have a 2nd renewal draft that they are able to submit in the future.

2 questions:

1. We should probably build some kind of constraints in STRR that does not allow more than 1 renewal for the period to be submitted. Do you want me to create a ticket for this?
2. How do we want to proceed with cleanup of the registrations that have had 2 separate renewal applications submitted? My understanding is that their expiry date is a year ahead of where it should be.