Skip to content

Commit 21cd122

Browse files
CeRiAllukasmalkmus
authored andcommitted
Axiom/Datasets_Integration_Test: Simplify TestIngestWithMapFields
1 parent 3204cca commit 21cd122

File tree

1 file changed

+11
-45
lines changed

1 file changed

+11
-45
lines changed

axiom/datasets_integration_test.go

Lines changed: 11 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -578,15 +578,6 @@ func (s *DatasetsTestSuite) TestMapFields() {
578578

579579
const (
580580
ingestDataMapFields1 = `[
581-
{
582-
"foo": {
583-
"bar": "val_bar",
584-
"bar2": "val_bar2"
585-
}
586-
}
587-
]`
588-
589-
ingestDataMapFields2 = `[
590581
{
591582
"foo": {
592583
"buz": "val_buz",
@@ -595,7 +586,7 @@ const (
595586
}
596587
]`
597588

598-
ingestDataMapFields3 = `[
589+
ingestDataMapFields2 = `[
599590
{
600591
"foo": {
601592
"qux": "val_qux",
@@ -647,10 +638,14 @@ func (s *DatasetsTestSuite) TestIngestWithMapFields() {
647638
startTime := now.Add(-time.Minute)
648639
endTime := now.Add(2 * time.Minute)
649640

641+
// Define 'foo' as a map field.
642+
err := s.client.Datasets.CreateMapField(s.ctx, s.dataset.ID, "foo")
643+
s.Require().NoError(err)
644+
650645
// Ingest some data containing an object.
651646
ingestObjectDataFn(s, ingestDataMapFields1)
652647

653-
// Run a simple APL query...
648+
// Run another simple APL query...
654649
apl := fmt.Sprintf("['%s']", s.dataset.ID)
655650
queryResult, err := s.client.Datasets.Query(s.ctx, apl,
656651
query.SetStartTime(startTime),
@@ -667,19 +662,18 @@ func (s *DatasetsTestSuite) TestIngestWithMapFields() {
667662
if s.Len(table.Sources, 1) {
668663
s.Equal(s.dataset.ID, table.Sources[0].Name)
669664
}
670-
s.Len(table.Fields, 2+numExtraFields)
671-
s.Len(table.Columns, 2+numExtraColumns)
665+
s.Len(table.Fields, 1+numExtraFields)
666+
s.Len(table.Columns, 1+numExtraColumns)
672667
}
673668

674-
// Define 'foo' as a map field.
675-
err = s.client.Datasets.CreateMapField(s.ctx, s.dataset.ID, "foo")
669+
// Remove 'foo' from the map fields.
670+
err = s.client.Datasets.DeleteMapField(s.ctx, s.dataset.ID, "foo")
676671
s.Require().NoError(err)
677672

678-
// Now ingest some more data.
673+
// Ingest some more data.
679674
ingestObjectDataFn(s, ingestDataMapFields2)
680675

681676
// Run another simple APL query...
682-
apl = fmt.Sprintf("['%s']", s.dataset.ID)
683677
queryResult, err = s.client.Datasets.Query(s.ctx, apl,
684678
query.SetStartTime(startTime),
685679
query.SetEndTime(endTime),
@@ -698,34 +692,6 @@ func (s *DatasetsTestSuite) TestIngestWithMapFields() {
698692
s.Len(table.Fields, 3+numExtraFields)
699693
s.Len(table.Columns, 3+numExtraColumns)
700694
}
701-
702-
// Remove 'foo' from the map fields.
703-
err = s.client.Datasets.DeleteMapField(s.ctx, s.dataset.ID, "foo")
704-
s.Require().NoError(err)
705-
706-
// Now ingest even more data.
707-
ingestObjectDataFn(s, ingestDataMapFields3)
708-
709-
// Run another simple APL query...
710-
apl = fmt.Sprintf("['%s']", s.dataset.ID)
711-
queryResult, err = s.client.Datasets.Query(s.ctx, apl,
712-
query.SetStartTime(startTime),
713-
query.SetEndTime(endTime),
714-
)
715-
s.Require().NoError(err)
716-
s.Require().NotNil(queryResult)
717-
718-
s.NotZero(queryResult.Status.ElapsedTime)
719-
s.EqualValues(3, queryResult.Status.RowsExamined)
720-
s.EqualValues(3, queryResult.Status.RowsMatched)
721-
if s.Len(queryResult.Tables, 1) {
722-
table := queryResult.Tables[0]
723-
if s.Len(table.Sources, 1) {
724-
s.Equal(s.dataset.ID, table.Sources[0].Name)
725-
}
726-
s.Len(table.Fields, 5+numExtraFields)
727-
s.Len(table.Columns, 5+numExtraColumns)
728-
}
729695
}
730696

731697
func getEventChan() <-chan axiom.Event {

0 commit comments

Comments
 (0)