`ark_grpc::Client::connect()` regressed TLS for HTTPS ASPs in v0.9.1

[Jeezman]

Summary

PR #229 rewrote ark_grpc::Client::connect() to construct the gRPC channel manually via
tonic::transport::Endpoint::from_shared(url).connect() instead of the generated ArkServiceClient::connect(url) static. The manual path does not configure TLS, so consumers hitting an https:// ASP fail.

Confirmed in v0.9.1 (also present on master HEAD). v0.9.0 was unaffected.

Reproduction

Any consumer of ark-grpc v0.9.1 with default features against an HTTPS Ark server:

let mut client = ark_grpc::Client::new("https://your-asp.example.com".into());
client.connect().await?; // fails with `tonic::transport::Error`, kind "transport error"

Reproduced against a locally developed arkade wallet on bitcoin mainnet, hitting (https://arkade.computer). Same wallet code on v0.9.0 connected fine

[arkanaai]

Debug Analysis

Root cause confirmed. PR #229 (feat/send-version-master) changed connect() in ark-grpc/src/client.rs:117 from:

// v0.9.0 — static connect, infers TLS from scheme
let ark_service_client = ArkServiceClient::connect(self.url.clone()).await?;

to:

// v0.9.1 — manual Endpoint, does NOT infer TLS from scheme
let channel = tonic::transport::Endpoint::from_shared(self.url.clone())
    .map_err(Error::connect)?
    .connect()
    .await
    .map_err(Error::connect)?;

Why from_shared breaks HTTPS: tonic::transport::Endpoint::from_shared() accepts arbitrary bytes and does not parse the URL scheme — it creates a plaintext channel regardless of whether the URL is https://. Endpoint::new() (and the generated ::connect() statics) do parse the scheme and auto-configure TLS for https:// URIs.

TLS features are present — ark-grpc/Cargo.toml has tls-webpki-roots as the default feature, so TLS support is compiled in. The issue is purely the channel construction path.

Fix: Change from_shared → new at ark-grpc/src/client.rs:117:

// Fix: Endpoint::new() parses the URI scheme and enables TLS for https://
let channel = tonic::transport::Endpoint::new(self.url.clone())
    .map_err(Error::connect)?
    .connect()
    .await
    .map_err(Error::connect)?;

This one-line change is already authored as a standalone commit on an internal branch. It is not yet merged to master — v0.9.2+ on master currently also regresses HTTPS connections.

Affected: Any ark-grpc consumer hitting an https:// ASP since v0.9.1. ark-rest is unaffected (uses reqwest which respects the URL scheme). ark-delegator had a similar TLS fix already applied in fix(delegator): enable TLS backend for reqwest client.