feat: Only sync controller owner references if an annotation is present #24814
Conversation
❌ Preview Environment undeployed from BunnyshellAvailable commands (reply to this comment):
|
Signed-off-by: Dave Protasowski <[email protected]>
dprotaso
force-pushed
the
controller-refs
branch
from
3554808 to
1ca7d99
Compare
dprotaso
changed the title
dprotaso
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24814 +/- ##
=========================================
Coverage ? 60.79%
=========================================
Files ? 404
Lines ? 66224
Branches ? 0
=========================================
Hits ? 40262
Misses ? 22719
Partials ? 3243 ☔ View full report in Codecov by Sentry. |
| if resource.HasAnnotationOption(un, common.AnnotationSyncOptions, common.SyncOptionControllerReferencesOnly) { | ||
| controllerOwnerRefs := []metav1.OwnerReference{} | ||
| for _, ownerRef := range un.GetOwnerReferences() { | ||
| if ownerRef.Controller != nil && *ownerRef.Controller { | ||
| controllerOwnerRefs = append(controllerOwnerRefs, ownerRef) | ||
| } | ||
| } | ||
| ownerRefs = controllerOwnerRefs | ||
| } | ||
|
|
There was a problem hiding this comment.
Is there any UT we can add / modify to cover this extra if block?
There was a problem hiding this comment.
This was someone else's PR that I ported over now 2x. Can you reference an existing test I can look at?
|
Does it make sense to eventually have this option on by default and then the annotation lets people turn the feature off if they need it |
|
/hold See: #11972 (comment) |
3 participants
This moves the rebase of argoproj/gitops-engine#771 into this repository
Part of #4764 #11972