Summary
Three defects in skills/license-compliance-audit/SKILL.md: a report cites a
file that only one code path writes, large files are silently miscounted, and
the SPDX matching accepts a token that is not valid SPDX.
Background
The skill has two scan paths, a local checkout and a github API scan, and the
reporting section assumes the local one. Of the three, the large-file case is
the one that produces wrong results a user would act on.
Where to look
- Line 215 writes
/tmp/lca-missing-spdx.txt, but only in the local-checkout
branch. Line 287 tells the reader to find the remaining files there, so in
github scan mode the citation points at a file never created.
- The github SPDX scan section -
gh api .../contents/<path> returns no content
for blobs over about 1MB. Those decode to empty and are counted
MISSING-SPDX-HEADER, a false positive. The Failure modes table has no row.
- Line 254 treats
Apache-2.0 and Apache 2.0 as equivalent. The spaced form is
not a valid SPDX identifier.
Acceptance criteria
Estimated effort
~3 hours for someone new to the codebase. The three are independent.
Summary
Three defects in
skills/license-compliance-audit/SKILL.md: a report cites afile that only one code path writes, large files are silently miscounted, and
the SPDX matching accepts a token that is not valid SPDX.
Background
The skill has two scan paths, a local checkout and a github API scan, and the
reporting section assumes the local one. Of the three, the large-file case is
the one that produces wrong results a user would act on.
Where to look
/tmp/lca-missing-spdx.txt, but only in the local-checkoutbranch. Line 287 tells the reader to find the remaining files there, so in
github scan mode the citation points at a file never created.
gh api .../contents/<path>returns no contentfor blobs over about 1MB. Those decode to empty and are counted
MISSING-SPDX-HEADER, a false positive. The Failure modes table has no row.Apache-2.0andApache 2.0as equivalent. The spaced form isnot a valid SPDX identifier.
Acceptance criteria
/tmp/lca-missing-spdx.txton the path that writesit, or both paths write it.
why the leniency is deliberate.
skill-and-tool-validatestill passes.Estimated effort
~3 hours for someone new to the codebase. The three are independent.