Skip to content

Conversation

@heguanhui
Copy link
Contributor

What problem does this PR solve?

Fix partitions() function throw error when query internal table without specifying catalog condition, this incompatible with show partitions command

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…ernal table without specifying catalog condition, this incompatible with show partitions command
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@heguanhui
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32176 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 77422560bee5a403d01f5cb8212bfeda2d9dd020, data reload: false

------ Round 1 ----------------------------------
q1	17604	5231	5054	5054
q2	2029	300	192	192
q3	10204	1299	733	733
q4	10225	869	310	310
q5	7556	2068	1927	1927
q6	190	178	146	146
q7	868	734	598	598
q8	9244	1274	1103	1103
q9	5482	4816	4731	4731
q10	6824	1930	1545	1545
q11	499	276	268	268
q12	335	371	228	228
q13	17788	4048	3221	3221
q14	229	240	226	226
q15	882	822	833	822
q16	689	667	615	615
q17	660	852	405	405
q18	6704	6491	6336	6336
q19	1255	991	612	612
q20	398	334	233	233
q21	2531	1924	1929	1924
q22	1029	1043	947	947
Total cold run time: 103225 ms
Total hot run time: 32176 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5344	5308	5289	5289
q2	264	348	243	243
q3	2160	2625	2233	2233
q4	1342	1719	1346	1346
q5	4241	4237	4258	4237
q6	218	182	139	139
q7	2253	2086	1844	1844
q8	2617	2462	2389	2389
q9	7490	7404	7726	7404
q10	2939	2956	2611	2611
q11	546	476	450	450
q12	658	736	606	606
q13	3873	4450	3596	3596
q14	301	332	291	291
q15	879	842	819	819
q16	671	779	685	685
q17	1211	1360	1340	1340
q18	8048	7749	7732	7732
q19	845	867	884	867
q20	2109	2226	1895	1895
q21	4492	4131	4042	4042
q22	1100	1018	965	965
Total cold run time: 53601 ms
Total hot run time: 51023 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.19 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 77422560bee5a403d01f5cb8212bfeda2d9dd020, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.04	0.04
query3	0.26	0.09	0.08
query4	1.61	0.11	0.10
query5	0.26	0.26	0.24
query6	1.17	0.68	0.67
query7	0.03	0.02	0.02
query8	0.05	0.04	0.05
query9	0.56	0.50	0.50
query10	0.55	0.55	0.55
query11	0.14	0.09	0.09
query12	0.13	0.10	0.11
query13	0.63	0.61	0.62
query14	1.05	1.04	1.05
query15	0.87	0.87	0.86
query16	0.38	0.38	0.39
query17	1.13	1.12	1.18
query18	0.22	0.21	0.20
query19	2.00	2.04	2.02
query20	0.02	0.02	0.02
query21	15.40	0.24	0.14
query22	5.21	0.05	0.05
query23	15.93	0.28	0.10
query24	1.84	0.24	0.26
query25	0.12	0.05	0.06
query26	0.14	0.15	0.13
query27	0.07	0.06	0.05
query28	3.52	1.14	0.97
query29	12.53	3.94	3.18
query30	0.29	0.13	0.14
query31	2.81	0.62	0.40
query32	3.22	0.58	0.49
query33	3.32	3.22	3.31
query34	16.30	5.39	4.73
query35	4.80	4.84	4.72
query36	0.65	0.51	0.48
query37	0.12	0.07	0.07
query38	0.08	0.04	0.04
query39	0.05	0.03	0.03
query40	0.18	0.16	0.15
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.96 s
Total hot run time: 28.19 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 50.00% (2/4) 🎉
Increment coverage report
Complete coverage report

@heguanhui heguanhui changed the title [Fix] (function) fix partitions() function throw error when query internal table without specifying catalog condition, this incompatible with show partitions command [Fix](function) fix partitions function throw error when query internal table without specifying catalog condition, this incompatible with show partitions command Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants