Remove Nif Tests and replace them with Examples #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to check properties of the data structures that we require to be valid to be considered legal
Without this change any assertions in lib/ will cause dialyzer to fail, this fixes this issue and allows examples to be written
This is mostly from the AnomaSDK.Validate, however not everything is a data structure, so sometimes functions are used instead
We mainly replace the old by hand calls in the tests with the new interface and calls. This will make it easier to export these as examples, as no more test fixtures will be needed
Before the tests did the same checks by hand over and over, we promote these to examples along with automating the process so we can reduce repeat code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the tests did the same checks by hand over and over, we promote
these to examples along with automating the process so we can reduce
repeat code