Skip to content

context.isMaster property is true across multiple amp-ad tags frames #40447

@PsychodelEKS

Description

@PsychodelEKS

Description

Trying to use isMaster to determine main thread to reuse resources properly, but seem like this property is set true in all frames. Am I missing smth?

Reproduction Steps

I used this example playground and devtools to check the value from the console using frames contexts.

Example page html

<!doctype html>
<html >
<head>
  <meta charset="utf-8">
  <title>amp-ad - Example 1</title>
  <script async src="https://cdn.ampproject.org/v0.js"></script>
  <script custom-element="amp-ad" src="https://cdn.ampproject.org/v0/amp-ad-0.1.js" async></script>
  <link rel="canonical" href="https://preview.amp.dev/documentation/components/amp-ad.example.1.html">
  <meta name="viewport" content="width=device-width">
  <style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
</head>
<body>

<amp-ad
  width="300"
  height="250"
  type="industrybrains"
  data-width="300"
  data-height="250"
  data-cid="19626-3798936394"
>
</amp-ad>
<amp-ad
  width="300"
  height="250"
  type="industrybrains"
  data-width="300"
  data-height="250"
  data-cid="19626-3798936394"
>
</amp-ad>
  
</body>
</html>

Relevant Logs

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions