Skip to content

Conversation

@LandonMoss
Copy link

This pull request introduces several enhancements to the disk.js file, improving the functionality and reliability of disk monitoring in the application. Here's a summary of the changes:

  1. Error Handling: Implemented error handling to gracefully manage cases where fetching disk information fails, ensuring the application handles errors more robustly.

  2. Disk Usage Threshold Alerts: Added functionality to trigger alerts when disk usage exceeds a specified threshold. Alerts are triggered based on the configured threshold percentage, providing timely notifications to users about high disk usage.

  3. Performance Optimization: Reviewed and optimized the update frequency and data processing in the disk monitoring module, improving performance and reducing resource usage.

Please review the changes and provide feedback. Thank you!

@WolfFlightTZW
Copy link

interrogative: Does this provide accurate disk usage monitoring. In its current configuration, for me (on PopOS currently) it shows disk usage for one of my tmpfs mounts and not the actual mount of my primary drive. The data on disk usage is essentially worthless to me using gtop. I should note for example that when using btop, I see drive information from multiple mounts. Including and most importantly for /

@LandonMoss
Copy link
Author

Displays data for a tmpfs mount instead of your actual primary drive. This issue makes the disk usage data essentially worthless for your use case, especially when compared to other monitoring tools like btop, which correctly displays drive information from multiple mounts, including the primary drive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants