-
-
Notifications
You must be signed in to change notification settings - Fork 68
Add TypeDict object for typehinting for Exception handler callbacks #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
…onex/aiojobs into ExceptionHandler-Improvement
for more information, see https://pre-commit.ci
Co-authored-by: Sam Bull <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Sam Bull <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Sam Bull <[email protected]>
|
@Dreamsorcerer I'll come back sometime in a couple of hours later today to mark a few mypy things off as ignorable because the default handler expects a something other than a context instead of something else. Here's the error from the workflow if you need a bit of context something to mark these as truthy in the python code might be nessesary... |
|
aiojobs/_scheduler.py:239:63 is essentially a bug/limitation in mypy. The others are typing issues in our code that should be fixed. |
What do these changes do?
These changes are made to better reflect the documentation on Exception Handlers as mentioned in #565
Might need a little help & Guidance with this one :/
Are there changes in behavior for the user?
Typehinting changes for Exception Handler Callbacks mainly meant to assist and add context from the provided documentation
Related issue number
Fixes #565
Checklist