Missing surface_area in stats

[mcorbe]

Thanks for the bindings, love it !

It seems that the surface area is missing from the ctypedef hence not accessible through the admesh.Stl objects

See: https://github.com/admesh/python-admesh/blob/v0.98.5/_cadmesh.pxd#L43

Should I create a pull request ?

[hroncok]

Actually, surface area is only present in API that's not yet released. If you need it, I can do a side branch for such things, i.e. for admesh's features and changes not yet released, but I will not release that on PyPI. If you can come with a nice idea how to only put it there is it's actually present in admesh (i.e. some #ifdef Cython alternative), that would be great, such PR would be appreciated.

[hroncok]

Actually looking at the code, the best approach would be to generate the ctypedefs from the header file, as it is currently done for functions.

[mcorbe]

That is what I have in mind too. Working for me on my host.

[hroncok]

I don't understand, what part are you referring to?

[mcorbe]

Adding ctypedefs in the pxd file. Would that work with you too or does it have implications that I don't see ?

(Sorry for closing wrong bouton from my phone)

[hroncok]

Released version of admesh dos not support surface_area. The Python admesh package (i.e. this repository) is designed to work with current (i.e. released) admesh version. If you can make it so that it would work with both released and unreleased admesh, feel free to propose a change via a pull request.

Continuous integration via Travis will check if your pull request compiles against stable admesh, some further test cases might be needed to check if it actually behaves correctly.

[mcorbe]

So, I don't have any clean solution to make it work with both released and current versions.

What is the plan with admesh releases actually ?

[hroncok]

I'm currently occupied with university finals happening in two weeks. During summer I want to fix issues from this milestone https://github.com/admesh/admesh/milestones/0.99 and release 0.99. (Feel free to go trough the list an help.) When 0.99 is released, all admesh projects needs to be updated as well, including Python and Ruby bindings.