-
Notifications
You must be signed in to change notification settings - Fork 103
Implement more GSP features #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| ad_utility::triple_component::Iri GraphStoreProtocol::generateGraphIri() { | ||
| ad_utility::SlowRandomIntGenerator<uint64_t> randGraphIriSuffix_; | ||
| return ad_utility::triple_component::Iri::fromIriref( | ||
| QLEVER_NEW_GRAPH_PREFIX + std::to_string(randGraphIriSuffix_()) + ">"); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this might (though probably more in theory than in practice) generate the same graph twice making it incorrect. Keeping tracks of all graphs and/or explicit graph existence would go beyond the scope of this PR. As an intermediate solution the graphs will be generated with the internal prefix and a counter.
| // For a `POST` when the graph identifies the QLever instance itself then | ||
| // the data must be stored in a newly generated graph which is returned in | ||
| // the response. | ||
| // TODO: test this with jena |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2532 +/- ##
==========================================
- Coverage 91.11% 90.88% -0.23%
==========================================
Files 466 471 +5
Lines 39777 40245 +468
Branches 5320 5389 +69
==========================================
+ Hits 36242 36576 +334
- Misses 2024 2139 +115
- Partials 1511 1530 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overview
Conformance check failed ❌Test Status Changes 📊
|
|



HEADoperation. Closes ad-freiburg/qlever-private#63PUT. Closes ad-freiburg/qlever-private#61POSTwhere the server creates a new graph. Note: the chosen graph is not guaranteed to not exist before. An intermediate solution could be to generate the graphs with a prefix and a counter. Knowing which graphs exist is a more involved task. Closes ad-freiburg/qlever-private#75Open questions: