Skip to content

Conversation

@Qup42
Copy link
Member

@Qup42 Qup42 commented Nov 24, 2025

  • Implement the HEAD operation. Closes ad-freiburg/qlever-private#63
  • Correct response status code for PUT. Closes ad-freiburg/qlever-private#61
  • Implement POST where the server creates a new graph. Note: the chosen graph is not guaranteed to not exist before. An intermediate solution could be to generate the graphs with a prefix and a counter. Knowing which graphs exist is a more involved task. Closes ad-freiburg/qlever-private#75

Open questions:

Comment on lines 102 to 106
ad_utility::triple_component::Iri GraphStoreProtocol::generateGraphIri() {
ad_utility::SlowRandomIntGenerator<uint64_t> randGraphIriSuffix_;
return ad_utility::triple_component::Iri::fromIriref(
QLEVER_NEW_GRAPH_PREFIX + std::to_string(randGraphIriSuffix_()) + ">");
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this might (though probably more in theory than in practice) generate the same graph twice making it incorrect. Keeping tracks of all graphs and/or explicit graph existence would go beyond the scope of this PR. As an intermediate solution the graphs will be generated with the internal prefix and a counter.

// For a `POST` when the graph identifies the QLever instance itself then
// the data must be stored in a newly generated graph which is returned in
// the response.
// TODO: test this with jena
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 38.50000% with 123 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.88%. Comparing base (6ee3a75) to head (3b83158).
⚠️ Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
src/engine/GraphManager.cpp 14.03% 49 Missing ⚠️
src/engine/Server.cpp 0.00% 21 Missing ⚠️
src/engine/GraphStoreProtocol.cpp 41.17% 20 Missing ⚠️
src/util/http/ResponseMiddleware.h 5.88% 16 Missing ⚠️
src/engine/GraphStoreProtocol.h 77.14% 8 Missing ⚠️
src/util/http/HttpUtils.h 75.00% 6 Missing and 2 partials ⚠️
src/engine/SparqlProtocol.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2532      +/-   ##
==========================================
- Coverage   91.11%   90.88%   -0.23%     
==========================================
  Files         466      471       +5     
  Lines       39777    40245     +468     
  Branches     5320     5389      +69     
==========================================
+ Hits        36242    36576     +334     
- Misses       2024     2139     +115     
- Partials     1511     1530      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Qup42 Qup42 requested a review from RobinTF November 25, 2025 08:54
@sparql-conformance
Copy link

Overview

Number of Tests Passed ✅ Failed ❌ Intended ⚠️ Not tested
458 382 76 0 0

Conformance check failed ❌

Test Status Changes 📊

Number of Tests Previous Status Current Status
1 Passed Failed
4 Failed Passed

Details: https://qlever.dev/sparql-conformance-ui?cur=3b83158296504374352ef17f50aa3d35bf4b07cc&prev=562396cc756734eaa6c24037373d7a911402270d

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant