Skip to content

bug(wave-status + skill): action lingers as waiting-ci after pr_merge — pre-flight #3 of next campaign could refuse #636

@bakeb7j0

Description

@bakeb7j0

Summary

After pr_merge lands, the wave-status action field lingers as waiting-ci (e.g. "waiting-ci — PR #X attempt N: 0/0 passed, 0 failed, 0 pending") instead of resetting to idle or waiting-on-meatbag. Pre-flight check #3 of the next /wavemachine invocation could refuse to start on this stale state.

Observed by orchestrator during Plan #607 — multiple pr_merge calls left action: waiting-ci — PR #621 attempt 58: 0/0 in state.json long after the merge actually completed and wave_flight_done was called. State only finally cleared at wave_complete.

Severity: low — doesn't block the current campaign, but creates a foot-gun for the next one if pre-flight checks are tightened.

Suggested fix: the action label should reset on wave_flight_done to merging (already happens), then to idle on wave_complete. The lingering waiting-ci value is being preserved past its valid lifetime.

Origin: Reported by sibling-campaign agent and independently observed in Plan #607. @Scryer to expand.

Implementation Steps

TBD — @Scryer to expand. Probably a state-transition cleanup in wave-status or in pr_merge_wait's post-merge handler.

Test Procedures

TBD — regression: pr_merge → assert action != "waiting-ci" within N seconds.

Acceptance Criteria

  • After pr_merge completes, action resets to a non-waiting-ci value (idle / waiting-on-meatbag / merging)
  • Stale waiting-ci doesn't persist into the next wave's pre-flight check
  • Regression test catches the regression

Dependencies

  • None

Metadata

Severity: severity::minor
Origin: sibling-campaign tracker + Plan #607 orchestrator observation. @Scryer owns expansion.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions