chore: remaining review-pass fixes

- node-wpapi.php enqueued browser/wpapi.min.js, a path nothing has ever
  built; with the hook-name typo fixed that would have become a live
  404 on every page load. Point it at the UMD bundle tsdown actually
  emits (dist/browser/wpapi.umd.js) and drop the SCRIPT_DEBUG branch —
  there is only one browser artifact now.
- update-default-routes-json.js attached its download-failure handler
  as a trailing .catch, so an exception thrown by the downstream
  simplify-and-write callback was misreported as "Could not download
  endpoint JSON". The handler now sits alongside the callback so
  downstream errors surface with their real stack.
- The superagent test directory held a single stub assertion but kept
  four config references alive (vitest include, eslint files, two npm
  scripts). Moved the test to tests/unit/superagent-stub.js and dropped
  the extra config surface.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: kadamwhite

build/scripts/update-default-routes-json.js

@@ -124,9 +124,11 @@ const getJSON = ( cbFn ) => {
 				return process.exit( 1 );
 			}
 
-			return response.json().then( cbFn );
+			return response.json();
 		} )
-		.catch( ( err ) => {
+		.then( cbFn, ( err ) => {
+			// Rejection handler alongside cbFn (rather than a trailing .catch) so
+			// errors thrown downstream in cbFn are not misreported as download failures.
 			console.error( '\nSomething went wrong! Could not download endpoint JSON.' );
 			console.error( err );
 			process.exit( 1 );

eslint.config.js

@@ -114,7 +114,7 @@ module.exports = tseslint.config(
 		rules: styleRules,
 	},
 	{
-		files: [ 'tests/**/*.js', 'fetch/tests/**/*.js', 'superagent/tests/**/*.js' ],
+		files: [ 'tests/**/*.js', 'fetch/tests/**/*.js' ],
 		languageOptions: {
 			globals: testGlobals,
 		},

node-wpapi.php

@@ -15,10 +15,7 @@
  * @return void
  */
 function enqueue_scripts() {
-  $uri = plugin_dir_url( __FILE__ ) . 'browser/wpapi.min.js';
-  if ( defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ) {
-    $uri = plugin_dir_url( __FILE__ ) . 'browser/wpapi.js';
-  }
+  $uri = plugin_dir_url( __FILE__ ) . 'dist/browser/wpapi.umd.js';
 
   // Read the package.json to derive the version number.
   $package = read_json( plugin_dir_path( __FILE__ ) . '/package.json' );

package.json

@@ -47,9 +47,9 @@
     "format:check": "prettier --check .",
     "watch": "vitest",
     "test:all": "vitest run",
-    "test:unit": "vitest run tests/unit fetch/tests/unit superagent/tests/unit",
+    "test:unit": "vitest run tests/unit fetch/tests/unit",
     "test:integration": "vitest run tests/integration --no-file-parallelism",
-    "test:ci": "npm run eslint && vitest run tests/unit fetch/tests/unit superagent/tests/unit --coverage",
+    "test:ci": "npm run eslint && vitest run tests/unit fetch/tests/unit --coverage",
     "pretest": "npm run lint || true",
     "test": "vitest run --coverage"
   },

superagent/tests/unit/superagent.js tests/unit/superagent-stub.jssuperagent/tests/unit/superagent.js renamed to tests/unit/superagent-stub.js

@@ -3,7 +3,7 @@
 describe( 'wpapi/superagent', () => {
 
 	it( 'throws an error directing consumers to the fetch-based default export', () => {
-		expect( () => require( '../../' ) ).toThrow( /wpapi\/superagent was removed in wpapi 2.0.0/ );
+		expect( () => require( '../../superagent' ) ).toThrow( /wpapi\/superagent was removed in wpapi 2.0.0/ );
 	} );
 
 } );

vitest.config.js

@@ -13,7 +13,6 @@ module.exports = defineConfig( {
 		include: [
 			'tests/**/*.js',
 			'fetch/tests/**/*.js',
-			'superagent/tests/**/*.js',
 		],
 		exclude: [
 			'**/node_modules/**',