Feature/join card#89
Open
becky-n wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements the “Join SSA” call-to-action banner/card on the homepage (Issue #73), adding a new reusable component and rendering it on the home route.
Changes:
- Added a new
JoinCardcomponent with heading, subtext, CTA, and a (currently placeholder) image area. - Rendered the
JoinCardon the home page (/) between the highlight section and Instagram feed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| web/src/components/JoinCard.tsx | Adds the new Join SSA CTA card component and its responsive layout/styles. |
| web/src/app/page.tsx | Imports and renders JoinCard on the homepage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+5
to
+6
| <div className="px-4 sm:px-6 md:px-8"> | ||
| <section className="mx-auto w-full max-w-230 overflow-hidden rounded-4xl bg-ssa-card shadow-[0px_3px_4px_1px_#00000040,1px_-5px_4.3px_0px_#D5D5D54D]"> |
Comment on lines
+27
to
+29
| <div className="flex flex-1 items-center justify-center bg-ssa-white p-4 sm:p-5 md:p-6 lg:p-7"> | ||
| <div className="flex aspect-4/3 w-full max-w-70 items-center justify-center rounded-2xl border-2 border-dashed border-ssa-muted-gold/40 bg-white text-center shadow-inner sm:max-w-80 lg:max-w-90"> | ||
| <span className="px-4 font-averia text-xl font-bold text-ssa-muted-gold sm:text-2xl"> |
joengy
approved these changes
May 24, 2026
Collaborator
joengy
left a comment
joengy
left a comment
There was a problem hiding this comment.
The join widget looks good to me.
oorjagandhi
requested changes
May 24, 2026
Collaborator
There was a problem hiding this comment.
Nice work!
Some feedback, could you please...
- make the component span the same width as the 'upcoming event' card
- change the colour of the right side to match Figma (it should be a slightly darker yellow)
- on mobile view the image half should disappear, instead of going under
- can u add this image in for now (so it looks polished for milestone - we can change it later)
Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implementation of the sign-up card. Paragraph is from figma, probably should be changed and only using placeholder image for now. Is also responsive.
Type of change
Checklist
feature/,fix/,chore/,hotfix/)Linked Issues
Closes #73