Skip to content

Combined single/multiplayer resources on play page#405

Merged
kmck133 merged 2 commits into
masterfrom
VPS-73/combine-single-multiplayer-resources
May 21, 2026
Merged

Combined single/multiplayer resources on play page#405
kmck133 merged 2 commits into
masterfrom
VPS-73/combine-single-multiplayer-resources

Conversation

@kmck133
Copy link
Copy Markdown
Contributor

@kmck133 kmck133 commented May 20, 2026

Issue

Resources UI looked different between singleplayer and multiplayer, and the Notes button in multiplayer had no text label.

Solution

Both modes now use the same ResourcesPanel component and button. A "Notes" button styled identically sits next to "Resources" in multiplayer. Removed PlayPageSideButton, ResourcesModal, and the old flag-based resource fetching.

Risk

Multiplayer scenarios using the old flag-based Resource model will no longer show those resources. The panel now reads from the collections system only.

Checklist

  • Acceptance criteria met
  • Wiki documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous integration build passing

@linear
Copy link
Copy Markdown

linear Bot commented May 20, 2026

VPS-73

@glybrio glybrio requested a review from harbassan May 21, 2026 01:36
Copy link
Copy Markdown
Member

@leowla leowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

Will need to clean up backend's old model in a separate ticket (/api/resources/*, groupGetResources, resourcesDao, resource model)

We could also migrate old data if its not too much of a hassle.

Copy link
Copy Markdown
Contributor

@del-ereno del-ereno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat works great

@kmck133 kmck133 merged commit cf8725e into master May 21, 2026
3 checks passed
@kmck133 kmck133 deleted the VPS-73/combine-single-multiplayer-resources branch May 21, 2026 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants