Vps 91/prevent last scene deletion#399
Open
rgin216 wants to merge 9 commits into
Open
Conversation
harbassan
reviewed
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Deleting the only scene in a scenario allowed the scenario to end up with no scenes. This caused the authoring page and scenario info page to crash because both reasonably expect every scenario to have at least one scene.
Solution
Scenarios are now created with an initial Scene 1 on the backend, making the “at least one scene” invariant true from creation.
The scene delete API now rejects attempts to delete the last remaining scene with a 409 response. The reorder API also rejects empty sceneId arrays, so a scenario cannot be reordered into having no scenes.
The authoring UI now disables the delete action when only one scene remains and restores the scene list if a delete request fails.
Risk
Low. The main behaviour change is that scenarios can no longer be empty. Any existing code or tests that expected newly created scenarios to have zero scenes may need updating.
Existing database records with no scenes are not automatically backfilled by this PR.
Checklist