fix(models): a llama.cpp user was locked out of their own model list

pkg/models kept its own local-vs-hosted list, and it had drifted from
config.IsLocalProvider — whose doc comment already claimed pkg/models deferred
to it. `local`, `llamacpp` and the `llama-cpp`/`llama_cpp` spellings were local
everywhere else and hosted here.

The consequence was not cosmetic: Find fails closed on a missing key, so a
llama.cpp user — whose server wants no credential at all — got "auth required"
and an EMPTY model list from `slmcode agent list`, the Studio's model picker
and the find_models tool. It now defers to the shared predicate.

The price preset had drifted the same way, and is fixed differently on purpose.
It gains the llama.cpp spellings but deliberately does NOT become
IsLocalProvider: that also covers `litellm` and `custom`, which are gateways
that can front a paid API, and a confident $0 over a real bill is worse than
showing nothing. The comment says so, because the obvious "cleanup" here is to
unify them and be wrong.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UiLDxnEu1Gf8Q5hWAFhaAd

Author: claude

pkg/config/config.go

@@ -1661,8 +1661,13 @@ func PricePresetRates(preset, provider string) (prompt, completion float64, ok b
 		name = NormalizeProvider(provider)
 	}
 	switch name {
-	case "local", "omlx", "ollama", "lmstudio", "vllm", "mlx":
-		return 0, 0, true // explicitly free / local
+	case "local", "omlx", "mlx", "ollama", "lmstudio", "vllm", "llamacpp", "llama-cpp", "llama_cpp":
+		// Servers that run on your own hardware: the tokens genuinely cost
+		// nothing. Deliberately NOT IsLocalProvider, which also covers
+		// `litellm` and `custom` — those are gateways that can front a paid
+		// API, and reporting a confident $0 for a real bill is worse than
+		// reporting nothing, which is what the `false` below produces.
+		return 0, 0, true
 	case "openai", "gpt":
 		// Ballpark GPT-4o-mini class ($/MTok) — not model-perfect; override with price_*.
 		return 0.15, 0.60, true

pkg/config/parallel_test.go

@@ -403,3 +403,24 @@ func TestANormalizedEndpointParses(t *testing.T) {
 		}
 	}
 }
+
+// ── Free means "runs on your hardware", not "local-ish" ──────────────────
+
+func TestAServerOnYourOwnHardwareCostsNothing(t *testing.T) {
+	for _, p := range []string{"local", "omlx", "mlx", "ollama", "lmstudio", "vllm", "llamacpp", "llama-cpp"} {
+		in, out, ok := PricePresetRates("auto", p)
+		if !ok || in != 0 || out != 0 {
+			t.Errorf("PricePresetRates(auto, %q) = %v/%v/%v, want a confident zero", p, in, out, ok)
+		}
+	}
+}
+
+// A gateway can front a paid API. A confident $0 over a real bill is worse than
+// showing nothing, which is what "not configured" produces.
+func TestAGatewayIsNotAssumedFree(t *testing.T) {
+	for _, p := range []string{"litellm", "custom"} {
+		if _, _, ok := PricePresetRates("auto", p); ok {
+			t.Errorf("%q was assumed free, but it can proxy a paid API", p)
+		}
+	}
+}

pkg/models/catalog.go

@@ -118,13 +118,17 @@ func ResolveAuth(cfg *config.Config) AuthStatus {
 	return st
 }
 
+// requiresAPIKey reports whether this provider needs a credential.
+//
+// Defers to config.IsLocalProvider, which is the single local-vs-hosted notion
+// in the codebase. It used to keep its own list, and the two had drifted:
+// `llamacpp` (and `local`, and the `llama-cpp`/`llama_cpp` spellings) were
+// local everywhere else and hosted here — so a llama.cpp user, whose server
+// wants no credential at all, got "auth required" and an EMPTY model list from
+// `slmcode agent list`, the Studio's model picker and the find_models tool,
+// because Find fails closed on a missing key.
 func requiresAPIKey(provider string) bool {
-	switch config.NormalizeProvider(provider) {
-	case "omlx", "ollama", "lmstudio", "vllm", "litellm", "custom":
-		return false
-	default:
-		return true
-	}
+	return !config.IsLocalProvider(provider)
 }
 
 // APIKeyEnvFor names the environment variable a provider's key lives in.

pkg/models/catalog_test.go

@@ -81,3 +81,46 @@ func TestFindFiltersQuery(t *testing.T) {
 		t.Fatalf("expected empty, got %v", cat.Models)
 	}
 }
+
+// ── One local-vs-hosted notion, not two ──────────────────────────────────
+//
+// This package kept its own list and it had drifted from config.IsLocalProvider
+// — whose doc comment already claimed pkg/models deferred to it. A llama.cpp
+// user, whose server wants no credential at all, got "auth required" and an
+// EMPTY model list from `slmcode agent list`, the Studio's model picker and the
+// find_models tool, because Find fails closed on a missing key.
+
+func TestEveryLocalProviderIsKeyless(t *testing.T) {
+	for _, p := range []string{
+		"local", "omlx", "mlx", "ollama", "lmstudio", "lm-studio", "lm_studio",
+		"vllm", "litellm", "custom", "llamacpp", "llama-cpp", "llama_cpp",
+	} {
+		if !config.IsLocalProvider(p) {
+			t.Fatalf("fixture is wrong: %q is not local, so this proves nothing", p)
+		}
+		if requiresAPIKey(p) {
+			t.Errorf("%q is a local server and needs no credential, but auth is required", p)
+		}
+	}
+}
+
+func TestEveryHostedProviderNeedsAKey(t *testing.T) {
+	for _, p := range []string{"openai", "openrouter", "groq", "together", "deepseek", "anthropic", "gemini"} {
+		if !requiresAPIKey(p) {
+			t.Errorf("%q is a hosted API and must require a credential", p)
+		}
+	}
+}
+
+// The regression that motivated it: a llama.cpp user with no key still gets
+// their model list.
+func TestALlamaCppUserIsNotLockedOutOfTheirOwnModels(t *testing.T) {
+	cfg := config.Default(t.TempDir())
+	cfg.Provider = "llamacpp"
+	cfg.APIKey = ""
+
+	st := ResolveAuth(cfg)
+	if st.Required {
+		t.Errorf("auth reported as required for a local llama.cpp server: %+v", st)
+	}
+}