-
Notifications
You must be signed in to change notification settings - Fork 18
Feature/autocomplete#149 #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saikarthikbattula
wants to merge
19
commits into
develop
from
feature/Autocomplete#149
base: develop
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2af86b1
#149 Autocomplete show if we have notes
saikarthikbattula 4e6a1c6
Quick Formatting Update
saikarthikbattula 8ca3960
Optimizations
saikarthikbattula 213a460
Formatting
saikarthikbattula 12228a5
Updates
saikarthikbattula dc62472
1f60237
Quick Formatting Update
saikarthikbattula 9b16a19
Optimizations
saikarthikbattula 048a6ba
Formatting
saikarthikbattula 56a06a3
Updates
saikarthikbattula 1204925
feat: optimize autocomplete caching with per-result TTL
saikarthikbattula 3d08548
Merge branch 'feature/Autocomplete#149' of https://github.com/UTDNebu…
saikarthikbattula 71b3aff
Update to route.ts
saikarthikbattula c4cc555
Update FormFile.tsx and Search Query.tsx
saikarthikbattula e705356
Merge branch 'develop' into feature/Autocomplete#149
saikarthikbattula 2878274
check
saikarthikbattula 261311f
check
saikarthikbattula 0fdde83
Merge branch 'feature/Autocomplete#149' of https://github.com/UTDNebu…
saikarthikbattula fc09ad2
revert SearchQuery.tsx
saikarthikbattula File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the idea of the caching in this file. I don't know if I'm doing a great job of reviewing it tho because I haven't really seen anything like this before. @nl32 do you think you might be able to take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this further myself, I like the caching idea. It does have a very large first load time of like 4 of so seconds for me which I am guessing is mostly fetching all the sections. Do you think we could combine your original approach and this new one by fetching
hasNotesfor only the results being returned and caching only those results instead of the whole DB? This would require each result to have it's own TTL. Can we also do a TTL of 1 minute so it's quicker to let you search for a course after uploading a note? Lmk if that makes senseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep that makes sense sorry for the delay got caught in studying for exams