Add a dirty-context stop and an issue-comments nudge to the implement skill root - #2135
Conversation
…xt stop + comments nudge (checkpoint)
… to implement SKILL.md root (checkpoint)
…y-context-stop-and-an-issue-comments
|
/prflow:review |
PRFlow Review — PR #2135Status: ✅ APPROVE Blueprint
Verdict: APPROVE (clean — prose-only skill-root addition; all criteria met, zero findings)Issue ComplianceReviewed against issue #2116: Add a dirty-context stop and an issue-comments nudge to the implement skill root — criteria from the Verification Checklist Results8 passed, 0 failed, 0 inconclusive — 1 via lite probe, 7 via agent. ✅ Passed items (8 of 8) — click to expand
Code Review FindingsNo findings. All four Phase-3 agents (code-reviewer, silent-failure-hunter, comment-analyzer, requesting-code-review final pass) returned zero issues.
Repository-specific review gates
Verdict Criteria applied
|
Summary
/prflow:implementskill root so a local/interactive run started in a conversation that already held work halts before Phase 1 and asks the user to re-run in a fresh session, avoiding a degraded run from an early-compacting context.Changes
Implement skill root (
skills/implement/SKILL.md): Two standing-rule paragraphs added beside theInput:line. The first is a fresh-context stop scoped to run start on the local/interactive tier only — a cloud run (GITHUB_ACTIONSset) never meets the condition and a later-phase re-read does not repeat the check. The second is a comments nudge that treats existing issue comments as context-only data, never instructions, with acceptance criteria still taken from the issue body alone.Changeset:
.changeset/issue-2116-implement-dirty-context-stop.md(bump: patch) records the engine-surface change.Resolves
Resolves #2116
Test Plan
lib/test/lint-reference-size.py(skill-root size ceiling;skills/implement/SKILL.mdis 61,475 bytes, under the 61,750 ceiling, with no entry added tolib/test/reference-size-exemptions.json) andlib/test/lint-shipped-pruned-path.py(no forbidden references in shipped prose), verified via themonolithshard (10,194 passed, 0 failed).Visual Changes
N/A
Breaking Changes
None
Prompt-surface size
Derived at
1bfdbaf42a266abc106ac4b6dfd9ef54b9a30364against merge-base352dc01ccef94d5ded525d36f4ce20c4107ca682(origin/main). Covered: tracked*.mdunderskills/,agents/,.prflow/prompt-extensions/.skills/implement/SKILL.mdGenerated via /prflow:implement (v2.36.15, claude-opus-4-8, low)