add curl to shell script

[ithinkido]

I came across your shell script for installing the latest processing version. Thanks very much for the doing this. I would like to make the suggestion to include install curl into the script to make this this truly automated. My Ubuntu live installation , for example, does not come with curl pre-installed.
Small add on to a great script.

[TechnologyClassroom]

Thank you!

It sounds easy to just add an apt install -y curl, but that only accounts for Debian based systems. Gentoo, Arch, Suse, and Red Hat based systems would need different commands. It might be better to check for curl and then add an echo and exit if curl is not found. Something like lines 30-36 of https://github.com/TechnologyClassroom/HardwareTest/blob/master/hwtest.sh would do the trick.

Give it a shot with a pull request. This should be pretty easy.

[ithinkido]

Ahh, That is a good point, I have zero knowledge over Gentoo, Arch, Suse or Red Hat systems., but I guess it is possibe to do a check on the OS
What do you think of

if [ ! -x /usr/bin/curl ] ; then
  echo "You do not have curl installed."
  echo "Attempting to install curl..."
  if grep -q debian /etc/*-release ; then
    apt-get update
    apt-get install -y curl
  elif grep -q arch /etc/*-release ; then
    pacman -Syy
    pacman -S curl
  elif grep -q fedora /etc/*-release ; then
    dnf install -y curl
  elif grep -q redhat /etc/*-release ; then
    yum install -y curl
  elif grep -q suse /etc/*-release ; then
    zypper refresh
    zypper install -y curl
  else
    echo "Distribution not recognized."
    echo "Install curl and rerun $0."
    exit 1
  fi
else
  echo "You have curl installed!"
fi

[TechnologyClassroom]

I made a few tweaks.

• Added a code block.
• Generalized /etc/*-release to maximize compatibility.
• Match ID_LIKE= in *-release.
• Switched to apt-get to increase compatibility with legacy systems.
• Removed sudo as the program requires root.
• Added else (optional).
• Added Arch, Fedora, Red Hat, Suse.
• Added some update commands.

If we are going to check for a bunch of different systems, maybe it would be better to use case instead of a second if.

Maybe we should add 'apt-get update` before the install as well.

Red Hat based systems use yum except for Fedora which uses dnf. Arch uses pacman. Suse uses zypper, but we can skip that one. Gentoo uses emerge, but we can skip that one too.

Red Hat based systems: yum install -y curl
Fedora: dnf install -y curl
Arch based systems: pacman -S curl

[ithinkido]

Thanks for the improvements. I am not able to add much more , I do not have Red Hat , Fedora nor Arch installed and I have no idea how I would check the results on grep -q debian /etc/*-release for those systems.

[TechnologyClassroom]

OK, I made some guesses and fleshed it out a bit more. I will check out what the actual results are later.

[TechnologyClassroom]

Maybe wget would be present in more systems by default. I chose curl because the script that I based this on used curl. I will think on this.

[ithinkido]

I started with this http://www.artsnova.com/processing/installing-processing-ubuntu-linux-tutorial.html#:~:text=%20Installing%20Processing%203.x%20on%20Ubuntu%20Linux%20Systems,is%20okay%2C%20it%20is%20much%20easier...%20More%20
so I was really happy to find your all in one script that also dealt with the versioning. Adding curl was a thought to just make this a one click job, but it is still a great tool with or without auto curl...