You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use case: We need to modify the filepath before we send it to launch-editor
Instead of providing a full configuration for a specific editor, wouldnt it be better to allow consumers to modify incomming parameters before they are sent to launch-editor? This way, a consumer can still use all the goodness launch-editor provides.
The current available options do allow you to override an editor, so you can certainly override editor with basically what DEFAULT_EDITOR_CONFIG provides. This might be cleaner since devtools already has a dependency on launch-editor.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Use case: We need to modify the filepath before we send it to
launch-editorInstead of providing a full configuration for a specific editor, wouldnt it be better to allow consumers to modify incomming parameters before they are sent to
launch-editor? This way, a consumer can still use all the goodnesslaunch-editorprovides.Something like this is desirable:
The current available options do allow you to override an editor, so you can certainly override editor with basically what
DEFAULT_EDITOR_CONFIGprovides. This might be cleaner since devtools already has a dependency onlaunch-editor.devtools/packages/devtools-vite/src/editor.ts
Lines 26 to 38 in d655b6c
Beta Was this translation helpful? Give feedback.
All reactions