Support iceberg schema type change#223
Open
sfc-gh-abozkurt wants to merge 1 commit into
Open
Conversation
sfc-gh-abozkurt
commented
Feb 23, 2026
| static void AssertInternalAndExternalIcebergDataFileColumnStatsMatch(List *internalColumnStatsList, | ||
| List *externalLowerBounds, | ||
| List *externalUpperBounds); | ||
| static void NormalizeColumnBound(Field * field, unsigned char *externalValue, |
Collaborator
Author
There was a problem hiding this comment.
note: we do not need these for the existing catalog values as we store them text. We can interpret them correctly when we cast their text value to new widen type.
That is only needed when we deserialize values of old type from parquet datafile or iceberg metadata.
sfc-gh-abozkurt
force-pushed
the
aykut/alter-iceberg-type
branch
2 times, most recently
from
1c4ecae to
525f874
Compare
sfc-gh-mslot
reviewed
Mar 2, 2026
sfc-gh-mslot
reviewed
Mar 2, 2026
sfc-gh-abozkurt
force-pushed
the
aykut/alter-iceberg-type
branch
4 times, most recently
from
7525ac3 to
a4c0a79
Compare
Signed-off-by: Aykut Bozkurt <aykut.bozkurt@snowflake.com>
sfc-gh-abozkurt
force-pushed
the
aykut/alter-iceberg-type
branch
from
a4c0a79 to
d6610a0
Compare
Collaborator
|
trying to change the type to numeric(39,8) proceeds, but causes downstream failures: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should support schema type evolution according to iceberg spec v2, our current iceberg implementation. This should not require data file rewrite, but metadata-only operation.
Closes #222.