WIP: Upgrade to LLVM 16.0.5 #734
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorbet builds have been failing on MacOS 26 (Tahoe) with the following error: ``` __DATA_CONST segment missing SG_READ_ONLY flag in /private/var/tmp/_bazel_emilysamp/d4f9f1bf3df434d7445caa2e7e6c895e/execroot/com_stripe_ruby_typer/bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/parser/parser/generate_diagnostics ``` This is because LLVM 15's linker doesn't apply the `SG_READ_ONLY` flag to these segments, and that is now required on the latest versions of MacOS. We are able to build again after upgrading LLVM to 16.0.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test plan
See included automated tests.