Migrate to ESLint 9 - Type and lint fixes

Author: gonzaloriestra

packages/app/src/cli/api/graphql/admin/generated/types.d.ts

@@ -1,53 +1,52 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any, tsdoc/syntax  */
+/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any, tsdoc/syntax, @typescript-eslint/no-duplicate-type-constituents, @typescript-eslint/no-redundant-type-constituents, @nx/enforce-module-boundaries  */
 import {JsonMapType} from '@shopify/cli-kit/node/toml'
-
-export type Maybe<T> = T | null
-export type InputMaybe<T> = Maybe<T>
-export type Exact<T extends {[key: string]: unknown}> = {[K in keyof T]: T[K]}
-export type MakeOptional<T, K extends keyof T> = Omit<T, K> & {[SubKey in K]?: Maybe<T[SubKey]>}
-export type MakeMaybe<T, K extends keyof T> = Omit<T, K> & {[SubKey in K]: Maybe<T[SubKey]>}
-export type MakeEmpty<T extends {[key: string]: unknown}, K extends keyof T> = {[_ in K]?: never}
-export type Incremental<T> = T | {[P in keyof T]?: P extends ' $fragmentName' | '__typename' ? T[P] : never}
+export type Maybe<T> = T | null;
+export type InputMaybe<T> = Maybe<T>;
+export type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };
+export type MakeOptional<T, K extends keyof T> = Omit<T, K> & { [SubKey in K]?: Maybe<T[SubKey]> };
+export type MakeMaybe<T, K extends keyof T> = Omit<T, K> & { [SubKey in K]: Maybe<T[SubKey]> };
+export type MakeEmpty<T extends { [key: string]: unknown }, K extends keyof T> = { [_ in K]?: never };
+export type Incremental<T> = T | { [P in keyof T]?: P extends ' $fragmentName' | '__typename' ? T[P] : never };
 /** All built-in and custom scalars, mapped to their actual values */
 export type Scalars = {
-  ID: {input: string; output: string}
-  String: {input: string; output: string}
-  Boolean: {input: boolean; output: boolean}
-  Int: {input: number; output: number}
-  Float: {input: number; output: number}
+  ID: { input: string; output: string; }
+  String: { input: string; output: string; }
+  Boolean: { input: boolean; output: boolean; }
+  Int: { input: number; output: number; }
+  Float: { input: number; output: number; }
   /**
    * An Amazon Web Services Amazon Resource Name (ARN), including the Region and account ID.
    * For more information, refer to [Amazon Resource Names](https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html).
    */
-  ARN: {input: any; output: any}
+  ARN: { input: any; output: any; }
   /**
    * Represents non-fractional signed whole numeric values. Since the value may
    * exceed the size of a 32-bit integer, it's encoded as a string.
    */
-  BigInt: {input: any; output: any}
+  BigInt: { input: any; output: any; }
   /**
    * A string containing a hexadecimal representation of a color.
    *
    * For example, "#6A8D48".
    */
-  Color: {input: any; output: any}
+  Color: { input: any; output: any; }
   /**
    * Represents an [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601)-encoded date string.
    * For example, September 7, 2019 is represented as `"2019-07-16"`.
    */
-  Date: {input: any; output: any}
+  Date: { input: any; output: any; }
   /**
    * Represents an [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601)-encoded date and time string.
    * For example, 3:50 pm on September 7, 2019 in the time zone of UTC (Coordinated Universal Time) is
    * represented as `"2019-09-07T15:50:00Z`".
    */
-  DateTime: {input: any; output: any}
+  DateTime: { input: any; output: any; }
   /**
    * A signed decimal number, which supports arbitrary precision and is serialized as a string.
    *
    * Example values: `"29.99"`, `"29.999"`.
    */
-  Decimal: {input: any; output: any}
+  Decimal: { input: any; output: any; }
   /**
    * A string containing a strict subset of HTML code. Non-allowed tags will be stripped out.
    * Allowed tags:
@@ -63,14 +62,14 @@ export type Scalars = {
    *
    * Example value: `"Your current domain is <strong>example.myshopify.com</strong>."`
    */
-  FormattedString: {input: any; output: any}
+  FormattedString: { input: any; output: any; }
   /**
    * A string containing HTML code. Refer to the [HTML spec](https://html.spec.whatwg.org/#elements-3) for a
    * complete list of HTML elements.
    *
    * Example value: `"<p>Grey cotton knit sweater.</p>"`
    */
-  HTML: {input: any; output: any}
+  HTML: { input: any; output: any; }
   /**
    * A [JSON](https://www.json.org/json-en.html) object.
    *
@@ -86,37 +85,37 @@ export type Scalars = {
    *   }
    * }`
    */
-  JSON: {input: JsonMapType | string; output: JsonMapType}
+  JSON: { input: JsonMapType | string; output: JsonMapType; }
   /** A monetary value string without a currency symbol or code. Example value: `"100.57"`. */
-  Money: {input: any; output: any}
+  Money: { input: any; output: any; }
   /**
    * Represents a unique identifier in the Storefront API. A `StorefrontID` value can
    * be used wherever an ID is expected in the Storefront API.
    *
    * Example value: `"Z2lkOi8vc2hvcGlmeS9Qcm9kdWN0LzEwMDc5Nzg1MTAw"`.
    */
-  StorefrontID: {input: any; output: any}
+  StorefrontID: { input: any; output: any; }
   /**
    * Represents an [RFC 3986](https://datatracker.ietf.org/doc/html/rfc3986) and
    * [RFC 3987](https://datatracker.ietf.org/doc/html/rfc3987)-compliant URI string.
    *
    * For example, `"https://example.myshopify.com"` is a valid URL. It includes a scheme (`https`) and a host
    * (`example.myshopify.com`).
    */
-  URL: {input: string; output: string}
+  URL: { input: string; output: string; }
   /**
    * An unsigned 64-bit integer. Represents whole numeric values between 0 and 2^64 - 1 encoded as a string of base-10 digits.
    *
    * Example value: `"50"`.
    */
-  UnsignedInt64: {input: any; output: any}
+  UnsignedInt64: { input: any; output: any; }
   /**
    * Time between UTC time and a location's observed time, in the format `"+HH:MM"` or `"-HH:MM"`.
    *
    * Example value: `"-07:00"`.
    */
-  UtcOffset: {input: any; output: any}
-}
+  UtcOffset: { input: any; output: any; }
+};
 
 /** Metafield access permissions for the Admin API. */
 export type MetafieldAdminAccess =
@@ -129,7 +128,7 @@ export type MetafieldAdminAccess =
   /** The merchant and other apps have read-only access. */
   | 'PUBLIC_READ'
   /** The merchant and other apps have read and write access. */
-  | 'PUBLIC_READ_WRITE'
+  | 'PUBLIC_READ_WRITE';
 
 /** Metafield access permissions for the Customer Account API. */
 export type MetafieldCustomerAccountAccess =
@@ -138,7 +137,7 @@ export type MetafieldCustomerAccountAccess =
   /** Read-only access. */
   | 'READ'
   /** Read and write access. */
-  | 'READ_WRITE'
+  | 'READ_WRITE';
 
 /** Possible types of a metafield's owner resource. */
 export type MetafieldOwnerType =
@@ -195,14 +194,14 @@ export type MetafieldOwnerType =
   /** The Shop metafield owner type. */
   | 'SHOP'
   /** The Validation metafield owner type. */
-  | 'VALIDATION'
+  | 'VALIDATION';
 
 /** Metafield access permissions for the Storefront API. */
 export type MetafieldStorefrontAccess =
   /** No access. */
   | 'NONE'
   /** Read-only access. */
-  | 'PUBLIC_READ'
+  | 'PUBLIC_READ';
 
 /**
  * Metaobject access permissions for the Admin API. When the metaobject is app-owned, the owning app always has
@@ -218,11 +217,11 @@ export type MetaobjectAdminAccess =
   /** The merchant and other apps have read-only access. */
   | 'PUBLIC_READ'
   /** The merchant and other apps have read and write access. */
-  | 'PUBLIC_READ_WRITE'
+  | 'PUBLIC_READ_WRITE';
 
 /** Metaobject access permissions for the Storefront API. */
 export type MetaobjectStorefrontAccess =
   /** No access. */
   | 'NONE'
   /** Read-only access. */
-  | 'PUBLIC_READ'
+  | 'PUBLIC_READ';

packages/app/src/cli/api/graphql/app-dev/generated/types.d.ts

@@ -1,26 +1,25 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any, tsdoc/syntax  */
+/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any, tsdoc/syntax, @typescript-eslint/no-duplicate-type-constituents, @typescript-eslint/no-redundant-type-constituents, @nx/enforce-module-boundaries  */
 import {JsonMapType} from '@shopify/cli-kit/node/toml'
-
-export type Maybe<T> = T | null
-export type InputMaybe<T> = Maybe<T>
-export type Exact<T extends {[key: string]: unknown}> = {[K in keyof T]: T[K]}
-export type MakeOptional<T, K extends keyof T> = Omit<T, K> & {[SubKey in K]?: Maybe<T[SubKey]>}
-export type MakeMaybe<T, K extends keyof T> = Omit<T, K> & {[SubKey in K]: Maybe<T[SubKey]>}
-export type MakeEmpty<T extends {[key: string]: unknown}, K extends keyof T> = {[_ in K]?: never}
-export type Incremental<T> = T | {[P in keyof T]?: P extends ' $fragmentName' | '__typename' ? T[P] : never}
+export type Maybe<T> = T | null;
+export type InputMaybe<T> = Maybe<T>;
+export type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };
+export type MakeOptional<T, K extends keyof T> = Omit<T, K> & { [SubKey in K]?: Maybe<T[SubKey]> };
+export type MakeMaybe<T, K extends keyof T> = Omit<T, K> & { [SubKey in K]: Maybe<T[SubKey]> };
+export type MakeEmpty<T extends { [key: string]: unknown }, K extends keyof T> = { [_ in K]?: never };
+export type Incremental<T> = T | { [P in keyof T]?: P extends ' $fragmentName' | '__typename' ? T[P] : never };
 /** All built-in and custom scalars, mapped to their actual values */
 export type Scalars = {
-  ID: {input: string; output: string}
-  String: {input: string; output: string}
-  Boolean: {input: boolean; output: boolean}
-  Int: {input: number; output: number}
-  Float: {input: number; output: number}
+  ID: { input: string; output: string; }
+  String: { input: string; output: string; }
+  Boolean: { input: boolean; output: boolean; }
+  Int: { input: number; output: number; }
+  Float: { input: number; output: number; }
   /**
    * Represents an [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601)-encoded date and time string.
    * For example, 3:50 pm on September 7, 2019 in the time zone of UTC (Coordinated Universal Time) is
    * represented as `"2019-09-07T15:50:00Z`".
    */
-  DateTime: {input: any; output: any}
+  DateTime: { input: any; output: any; }
   /**
    * A [JSON](https://www.json.org/json-en.html) object.
    *
@@ -36,13 +35,13 @@ export type Scalars = {
    *   }
    * }`
    */
-  JSON: {input: JsonMapType | string; output: JsonMapType}
+  JSON: { input: JsonMapType | string; output: JsonMapType; }
   /**
    * Represents an [RFC 3986](https://datatracker.ietf.org/doc/html/rfc3986) and
    * [RFC 3987](https://datatracker.ietf.org/doc/html/rfc3987)-compliant URI string.
    *
    * For example, `"https://example.myshopify.com"` is a valid URL. It includes a scheme (`https`) and a host
    * (`example.myshopify.com`).
    */
-  URL: {input: string; output: string}
-}
+  URL: { input: string; output: string; }
+};

packages/app/src/cli/api/graphql/app-management/generated/specifications.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/no-duplicate-type-constituents */
+/* eslint-disable @typescript-eslint/consistent-type-definitions */
 import * as Types from './types.js'
 
 import {TypedDocumentNode as DocumentNode} from '@graphql-typed-document-node/core'

packages/app/src/cli/api/graphql/app-management/generated/types.d.ts

@@ -1,26 +1,25 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any, tsdoc/syntax  */
+/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/naming-convention, @typescript-eslint/no-explicit-any, tsdoc/syntax, @typescript-eslint/no-duplicate-type-constituents, @typescript-eslint/no-redundant-type-constituents, @nx/enforce-module-boundaries  */
 import {JsonMapType} from '@shopify/cli-kit/node/toml'
-
-export type Maybe<T> = T | null
-export type InputMaybe<T> = Maybe<T>
-export type Exact<T extends {[key: string]: unknown}> = {[K in keyof T]: T[K]}
-export type MakeOptional<T, K extends keyof T> = Omit<T, K> & {[SubKey in K]?: Maybe<T[SubKey]>}
-export type MakeMaybe<T, K extends keyof T> = Omit<T, K> & {[SubKey in K]: Maybe<T[SubKey]>}
-export type MakeEmpty<T extends {[key: string]: unknown}, K extends keyof T> = {[_ in K]?: never}
-export type Incremental<T> = T | {[P in keyof T]?: P extends ' $fragmentName' | '__typename' ? T[P] : never}
+export type Maybe<T> = T | null;
+export type InputMaybe<T> = Maybe<T>;
+export type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };
+export type MakeOptional<T, K extends keyof T> = Omit<T, K> & { [SubKey in K]?: Maybe<T[SubKey]> };
+export type MakeMaybe<T, K extends keyof T> = Omit<T, K> & { [SubKey in K]: Maybe<T[SubKey]> };
+export type MakeEmpty<T extends { [key: string]: unknown }, K extends keyof T> = { [_ in K]?: never };
+export type Incremental<T> = T | { [P in keyof T]?: P extends ' $fragmentName' | '__typename' ? T[P] : never };
 /** All built-in and custom scalars, mapped to their actual values */
 export type Scalars = {
-  ID: {input: string; output: string}
-  String: {input: string; output: string}
-  Boolean: {input: boolean; output: boolean}
-  Int: {input: number; output: number}
-  Float: {input: number; output: number}
+  ID: { input: string; output: string; }
+  String: { input: string; output: string; }
+  Boolean: { input: boolean; output: boolean; }
+  Int: { input: number; output: number; }
+  Float: { input: number; output: number; }
   /**
    * Represents an [ISO 8601](https://en.wikipedia.org/wiki/ISO_8601)-encoded date and time string.
    * For example, 3:50 pm on September 7, 2019 in the time zone of UTC (Coordinated Universal Time) is
    * represented as `"2019-09-07T15:50:00Z`".
    */
-  DateTime: {input: any; output: any}
+  DateTime: { input: any; output: any; }
   /**
    * A [JSON](https://www.json.org/json-en.html) object.
    *
@@ -36,24 +35,24 @@ export type Scalars = {
    *   }
    * }`
    */
-  JSON: {input: JsonMapType | string; output: JsonMapType}
+  JSON: { input: JsonMapType | string; output: JsonMapType; }
   /**
    * Represents an [RFC 3986](https://datatracker.ietf.org/doc/html/rfc3986) and
    * [RFC 3987](https://datatracker.ietf.org/doc/html/rfc3987)-compliant URI string.
    *
    * For example, `"https://example.myshopify.com"` is a valid URL. It includes a scheme (`https`) and a host
    * (`example.myshopify.com`).
    */
-  URL: {input: string; output: string}
-}
+  URL: { input: string; output: string; }
+};
 
 /** The input fields used to create a new app version. */
 export type AppVersionInput = {
   /** The manifest from which to create the app version. */
-  source?: InputMaybe<Scalars['JSON']['input']>
+  source?: InputMaybe<Scalars['JSON']['input']>;
   /** URL referencing the source from which to create the app version. */
-  sourceUrl?: InputMaybe<Scalars['URL']['input']>
-}
+  sourceUrl?: InputMaybe<Scalars['URL']['input']>;
+};
 
 /** Possible error codes that can be returned by AppManagement. */
 export type Code =
@@ -70,21 +69,21 @@ export type Code =
   /** A plugin error. */
   | 'PLUGIN'
   /** An unknown error. */
-  | 'UNKNOWN'
+  | 'UNKNOWN';
 
 /** File extension for compressed files used for app sources. */
 export type SourceExtension =
   /** Brotli file extension. */
   | 'BR'
   /** ZIP file extension. */
-  | 'ZIP'
+  | 'ZIP';
 
 /** The input fields for app version metadata. */
 export type VersionMetadataInput = {
   /** Message associated with this app version. */
-  message?: InputMaybe<Scalars['String']['input']>
+  message?: InputMaybe<Scalars['String']['input']>;
   /** Link to version control, if any. */
-  sourceControlUrl?: InputMaybe<Scalars['URL']['input']>
+  sourceControlUrl?: InputMaybe<Scalars['URL']['input']>;
   /** Version tag associated with this app version. */
-  versionTag?: InputMaybe<Scalars['String']['input']>
-}
+  versionTag?: InputMaybe<Scalars['String']['input']>;
+};

packages/app/src/cli/api/graphql/bulk-operations/generated/bulk-operation-cancel.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/no-redundant-type-constituents */
+/* eslint-disable @typescript-eslint/consistent-type-definitions */
 import * as Types from './types.js'
 
 import {TypedDocumentNode as DocumentNode} from '@graphql-typed-document-node/core'

packages/app/src/cli/api/graphql/bulk-operations/generated/bulk-operation-run-mutation.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/no-redundant-type-constituents */
+/* eslint-disable @typescript-eslint/consistent-type-definitions */
 import * as Types from './types.js'
 
 import {TypedDocumentNode as DocumentNode} from '@graphql-typed-document-node/core'

packages/app/src/cli/api/graphql/bulk-operations/generated/bulk-operation-run-query.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/no-redundant-type-constituents */
+/* eslint-disable @typescript-eslint/consistent-type-definitions */
 import * as Types from './types.js'
 
 import {TypedDocumentNode as DocumentNode} from '@graphql-typed-document-node/core'

packages/app/src/cli/api/graphql/bulk-operations/generated/get-bulk-operation-by-id.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/no-redundant-type-constituents */
+/* eslint-disable @typescript-eslint/consistent-type-definitions */
 import * as Types from './types.js'
 
 import {TypedDocumentNode as DocumentNode} from '@graphql-typed-document-node/core'

packages/app/src/cli/api/graphql/bulk-operations/generated/list-bulk-operations.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/consistent-type-definitions, @typescript-eslint/no-redundant-type-constituents */
+/* eslint-disable @typescript-eslint/consistent-type-definitions */
 import * as Types from './types.js'
 
 import {TypedDocumentNode as DocumentNode} from '@graphql-typed-document-node/core'