remove useless sleeps from SessionHandlingTest

NB! This change decrease execution time of `SessionHandlingTest` from ~28s to 7s.

Author: asolntsev

java/test/org/openqa/selenium/SessionHandlingTest.java

@@ -17,22 +17,29 @@
 
 package org.openqa.selenium;
 
-import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+import static org.assertj.core.api.Assertions.*;
 import static org.openqa.selenium.testing.drivers.Browser.FIREFOX;
 import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
 
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.openqa.selenium.remote.RemoteWebDriver;
+import org.openqa.selenium.remote.SessionId;
 import org.openqa.selenium.testing.JupiterTestBase;
 import org.openqa.selenium.testing.NoDriverAfterTest;
 import org.openqa.selenium.testing.NotYetImplemented;
 
 class SessionHandlingTest extends JupiterTestBase {
+  @BeforeEach
+  void setUp() {
+    assertThat(getSessionId()).isNotNull();
+  }
 
   @NoDriverAfterTest
   @Test
   void callingQuitMoreThanOnceOnASessionIsANoOp() {
     driver.quit();
-    sleepTight(3000);
+    waitUntilBrowserFullyClosed();
     driver.quit();
   }
 
@@ -42,37 +49,36 @@ void callingQuitMoreThanOnceOnASessionIsANoOp() {
   @NotYetImplemented(SAFARI)
   public void callingQuitAfterClosingTheLastWindowIsANoOp() {
     driver.close();
-    sleepTight(3000);
     driver.quit();
   }
 
   @NoDriverAfterTest
   @Test
   void callingAnyOperationAfterClosingTheLastWindowShouldThrowAnException() {
     driver.close();
-    sleepTight(3000);
     assertThatExceptionOfType(NoSuchSessionException.class).isThrownBy(driver::getCurrentUrl);
   }
 
   @NoDriverAfterTest
   @Test
   void callingAnyOperationAfterQuitShouldThrowAnException() {
     driver.quit();
-    sleepTight(3000);
+    waitUntilBrowserFullyClosed();
     assertThatExceptionOfType(NoSuchSessionException.class).isThrownBy(driver::getCurrentUrl);
   }
 
   @Test
-  void shouldContinueAfterSleep() {
-    sleepTight(10000);
-    driver.getWindowHandle(); // should not throw
+  void shouldContinueAfterSleep() throws InterruptedException {
+    assertThatCode(() -> driver.getWindowHandle()).doesNotThrowAnyException();
+    Thread.sleep(50);
+    assertThatCode(() -> driver.getWindowHandle()).doesNotThrowAnyException();
+  }
+
+  private void waitUntilBrowserFullyClosed() {
+    wait.until($ -> getSessionId() == null);
   }
 
-  private void sleepTight(long duration) {
-    try {
-      Thread.sleep(duration);
-    } catch (InterruptedException e) {
-      e.printStackTrace();
-    }
+  private SessionId getSessionId() {
+    return ((RemoteWebDriver) driver).getSessionId();
   }
 }