Update prek schema to v0.4.13 - #6181
Merged
Merged
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by @j178 - if they write a comment saying "LGTM" then it will be merged. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the prek.toml JSON Schema in SchemaStore to align with prek v0.4.13 by expanding supported language/hook identifiers and adjusting hook description text.
Changes:
- Add
miseas a supported language (includingdefault_language_versionandLanguageenum). - Add builtin hook IDs
deny-filename-patternandrequire-filename-pattern. - Simplify hook
descriptionfield text (remove “For metadata only.”).
Suppressed comments (2)
src/schemas/json/prek.json:1007
- The new builtin hook id
deny-filename-patternis added to the schema enum, but the prek positive test does not include a config using this value. Add/extend a test case in src/test/prek/prek.toml that references this builtin hook id so the new enum value is covered by schema validation.
"check-xml",
"check-yaml",
"deny-filename-pattern",
"deny-pattern",
src/schemas/json/prek.json:1019
- The new builtin hook id
require-filename-patternis added to the schema enum, but there is no corresponding positive test exercising it. Please update/add a prek test case (e.g. in src/test/prek/prek.toml) that uses this builtin hook id to ensure the new enum value stays validated.
"no-commit-to-branch",
"pretty-format-json",
"require-filename-pattern",
"require-pattern",
"requirements-txt-fixer",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
LGTM |
Contributor
|
Merging because @j178 is a code-owner of all the changes - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update prek schema to v0.4.13