FIX duplicate attribute name in error message (Response.php)

zabous · web-flow · commit fb24228ac819 · 2025-07-25T09:26:08.000+02:00
Response.php; FIX duplicate attribute name in error message "Found an Attribute element with duplicated ...."
diff --git a/lib/Saml2/Response.php b/lib/Saml2/Response.php
@@ -795,7 +795,7 @@ private function _getAttributesByKeyName($keyName = "Name")
             if (in_array($attributeKeyName, array_keys($attributes), true)) {
                 if (!$allowRepeatAttributeName) {
                     throw new OneLogin_Saml2_ValidationError(
-                        "Found an Attribute element with duplicated ".$keyName,
+                        "Found an Attribute element with duplicated ".$attributeKeyName,
                         OneLogin_Saml2_ValidationError::DUPLICATED_ATTRIBUTE_NAME_FOUND
                     );
                 }

Original file line number	Diff line number	Diff line change
`@@ -795,7 +795,7 @@ private function _getAttributesByKeyName($keyName = "Name")`
`795`	`795`	`if (in_array($attributeKeyName, array_keys($attributes), true)) {`
`796`	`796`	`if (!$allowRepeatAttributeName) {`
`797`	`797`	`throw new OneLogin_Saml2_ValidationError(`
`798`		`- "Found an Attribute element with duplicated ".$keyName,`
	`798`	`+ "Found an Attribute element with duplicated ".$attributeKeyName,`
`799`	`799`	`OneLogin_Saml2_ValidationError::DUPLICATED_ATTRIBUTE_NAME_FOUND`
`800`	`800`	`);`
`801`	`801`	`}`