Skip to content

add mxfp8 support#838

Merged
coderfeli merged 6 commits into
mainfrom
mxfp8_dsl
Jul 13, 2026
Merged

add mxfp8 support#838
coderfeli merged 6 commits into
mainfrom
mxfp8_dsl

Conversation

@solinzby1

Copy link
Copy Markdown
Contributor

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Copilot AI review requested due to automatic review settings July 13, 2026 02:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds MXFP8 (E4M3) support to the existing preshuffle GEMM path by extending the MXFP4 preshuffle kernel to accept FP8 B operands, providing a per-1x32 FP8 quantization helper, and adding an A8W8 correctness/perf test (gfx950-only).

Changes:

  • Add per_1x32_f8_quant to generate MXFP8 (E4M3) codes plus per-32 E8M0 scales.
  • Extend kernels/gemm/mxfp4_preshuffle.py:launch_gemm with a b_dtype constexpr and FP8-B load/layout handling.
  • Add a new A8W8 (MXFP8×MXFP8) preshuffle GEMM test and plumb b_dtype through the test launcher.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/kernels/utils/fp4_utils.py Adds per-1x32 MXFP8 quantization helper for generating FP8 codes + E8M0 scales.
tests/kernels/test_preshuffle_gemm.py Adds an A8W8 FP8 MX preshuffle GEMM test and threads b_dtype into the launcher.
kernels/gemm/mxfp4_preshuffle.py Extends the preshuffle GEMM kernel to support FP8 B (fragment layout, view/strides, load path).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread kernels/gemm/mxfp4_preshuffle.py
Comment thread kernels/gemm/mxfp4_preshuffle.py
Comment thread tests/kernels/utils/gemm_common_utils.py
Comment thread tests/kernels/utils/gemm_common_utils.py
coderfeli
coderfeli previously approved these changes Jul 13, 2026
@coderfeli

Copy link
Copy Markdown
Collaborator

LGTM. perf numbers? @solinzby1

@coderfeli

Copy link
Copy Markdown
Collaborator

conflict @solinzby1

@solinzby1

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merged main into this branch. No conflicts were encountered — the merge resolved automatically. Commit: Merge origin/main into mxfp8_dsl to resolve conflicts.

@coderfeli coderfeli merged commit 14c0adc into main Jul 13, 2026
11 of 13 checks passed
@coderfeli coderfeli deleted the mxfp8_dsl branch July 13, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants