explode(): Argument #2 ($string) must be of type string, int given

[jaapjansma]

We have a matcher plugin with the following configuration:

{
  ...
  "required_values": [
    "btx.financial_type_id",
    "btx.campaign_id",
    "ogm_is_valid:not_in_constant:1"
  ],
...

When we try to analyse a transaction we get an error explode(): Argument #2 ($string) must be of type string, int given in org.project60.banking/CRM/Banking/PluginModel/BtxBase.php:62

Whlist we expect that analyzing to finish.

This error is on php version 8.3. The fix is quite straight foward and easy to implement.

[jaapjansma]

See #533 for a fix

[dontub]

In your example required_values is an array so I'd expect it to land here, not here. From my understanding of the code I'd expect the error to happen when required_values is specified as object with an integer as key, e.g.

"required_values": {
  "btx.financial_type_id": 123
}

Can you check if it's actually your configuration above that leads to the error?

[jaapjansma]

hey @dontub it is this line which causes the error: "ogm_is_valid:not_in_constant:1". The 1 in this configuration becomes an integer but with the explode php expects it as a string

[dontub]

I cannot see a way that this configuration reaches the explode() as explained above. I'm wondering if you have required_values used in any other configuration.

The "ogm_is_valid:not_in_constant:1" in your configuration should be handled in this line

org.project60.banking/CRM/Banking/PluginModel/BtxBase.php

Line 184 in 41b8bed

if ($this->getPropagationValue($btx, NULL, $required_key) == NULL) {

with $requird_key set to 'ogm_is_valid:not_in_constant:1' which will (most probably) always be TRUE resulting in FALSE being returned.

I think your given configuration should be:

"required_values": {
  "btx.financial_type_id": "type:not_empty",
  "btx.campaign_id": "type:not_empty",
  "btx.ogm_is_valid": "not_in_constant:1"
}

[jaapjansma]

@dontub this configuration is in production and exists already for a lot of years. It is broken now in our test environment where we did an upgrade of civi banking. It might be that is broken for all those years but I am not sure.

[jaapjansma]

I have changed the configuration and I still get the error. The issue is the number one after the not_in_constant:1.
Which is not a string but an integer.

[jaapjansma]

Ah it is a different configuration.

It was this:

  "penalties": [
    {
      "comment": "will prevent automatic execution, if a valid OGM is found for this transaction",
      "type": "attribute",
      "triggers": {
        "btx.ogm_is_valid": 1
      },
      "amount": 0.3
    }
  ],

putting " around "btx.ogm_is_valid": "1" solved it.

[jaapjansma]

Thanks @dontub

[dontub]

It will prevent the type exception, though I'm not sure it will do the expected thing. I think it will land here:

org.project60.banking/CRM/Banking/PluginModel/BtxBase.php

Line 64 in 41b8bed

error_log("org.project60.banking: required_value in config option not properly formatted, plugin id [{$this->_plugin_id}]");