Move client_min_messages suppression from the extension script to the test

An extension's own install script shouldn't unilaterally change a
session setting on its caller's behalf, even scoped via SET LOCAL --
that's the caller's call to make, not the extension's. Moved the
NOTICE suppression out of sql/object_reference.sql entirely; it turns
out only zzz_build's raw \i load (not the normal CREATE EXTENSION path
every other test uses) ever surfaced the %TYPE resolution NOTICEs in
the first place, so the fix belongs in that one test file, wrapped in
the transaction setup.sql already opens.

test/expected/zzz_build.out regenerated via make results (line-number
shift only, from the extension script shrinking).

Co-Authored-By: Claude <noreply@anthropic.com>

Author: jnasbyupgrade

sql/object_reference.sql

@@ -2,16 +2,6 @@
 \echo You really, REALLY do NOT want to try and load this via psql!!!
 \echo It will FAIL during pg_dump! \quit
 
-/*
- * SET LOCAL, not SET: this script runs inside CREATE EXTENSION's implicit
- * transaction, so LOCAL reverts automatically once it commits -- a plain SET
- * would leak into the installing session for the rest of its lifetime.
- * Suppresses NOTICEs like the %TYPE resolution messages this script's many
- * column-type references (e.g. _object_oid.objid%TYPE) would otherwise spam
- * CREATE EXTENSION's output with.
- */
-SET LOCAL client_min_messages = WARNING;
-
 /* EXCLUDED CODE: schema-restriction check below not currently enforced
 DO $$
 DECLARE

test/expected/zzz_build.out

@@ -2,16 +2,16 @@
 This extension must be loaded via CREATE EXTENSION object_reference;
 You really, REALLY do NOT want to try and load this via psql!!!
 
-psql:test/temp_load.not_sql:186: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
+psql:test/temp_load.not_sql:176: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
 
-psql:test/temp_load.not_sql:187: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
+psql:test/temp_load.not_sql:177: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
 
 
 
 
 
 
-psql:test/temp_load.not_sql:435: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
+psql:test/temp_load.not_sql:425: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
 
 
 
@@ -21,9 +21,9 @@ psql:test/temp_load.not_sql:435: WARNING:  I promise you will be sorry if you tr
 
 
 
-psql:test/temp_load.not_sql:547: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
+psql:test/temp_load.not_sql:537: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
 
-psql:test/temp_load.not_sql:554: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
+psql:test/temp_load.not_sql:544: WARNING:  I promise you will be sorry if you try to use this as anything other than an extension!
 
 
 

test/sql/zzz_build.sql

@@ -10,9 +10,18 @@ CREATE EXTENSION IF NOT EXISTS cat_tools;
 
 CREATE SCHEMA object_reference;
 
--- doesn't work :/ SET client_min_messages = FATAL; -- Need to surpress WARNING or turn down verbosity. Suppressing WARNING seems the better idea...
--- Need to do this instead so that results are stable across versions (no line #s from ereport messages)
+-- Need this so that results are stable across versions (no line #s from ereport messages)
 \set VERBOSITY default
+
+/*
+ * setup.sql above opened an explicit transaction (see the "TRANSACTION
+ * INTENTIONALLY LEFT OPEN!" notice below), so SET LOCAL here reverts when
+ * that transaction ends rather than leaking into the rest of the session.
+ * Squelches NOTICEs like the %TYPE resolution messages this raw \i load
+ * would otherwise spam the test output with -- scoped to this test only,
+ * not the shipped extension script itself.
+ */
+SET LOCAL client_min_messages = WARNING;
 \i test/temp_load.not_sql
 
 \echo Loaded OK!