Skip to content

Commit 75abc99

Browse files
jnasbyupgradeclaude
andcommitted
Fix multi-line comment to use block format, not consecutive -- lines
CODE_STYLE.md requires /* ... */ for multi-line SQL comments, never multi-line -- line comments. Applies to the client_min_messages explanation. test/expected/zzz_build.out regenerated via make results to reflect the resulting line-number shift in temp_load.not_sql's WARNING output. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 36005e5 commit 75abc99

2 files changed

Lines changed: 13 additions & 11 deletions

File tree

sql/object_reference.sql

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,14 @@
22
\echo You really, REALLY do NOT want to try and load this via psql!!!
33
\echo It will FAIL during pg_dump! \quit
44

5-
-- SET LOCAL, not SET: this script runs inside CREATE EXTENSION's implicit
6-
-- transaction, so LOCAL reverts automatically once it commits -- a plain SET
7-
-- would leak into the installing session for the rest of its lifetime.
8-
-- Suppresses NOTICEs like the %TYPE resolution messages this script's many
9-
-- column-type references (e.g. _object_oid.objid%TYPE) would otherwise spam
10-
-- CREATE EXTENSION's output with.
5+
/*
6+
* SET LOCAL, not SET: this script runs inside CREATE EXTENSION's implicit
7+
* transaction, so LOCAL reverts automatically once it commits -- a plain SET
8+
* would leak into the installing session for the rest of its lifetime.
9+
* Suppresses NOTICEs like the %TYPE resolution messages this script's many
10+
* column-type references (e.g. _object_oid.objid%TYPE) would otherwise spam
11+
* CREATE EXTENSION's output with.
12+
*/
1113
SET LOCAL client_min_messages = WARNING;
1214

1315
/*

test/expected/zzz_build.out

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
This extension must be loaded via CREATE EXTENSION object_reference;
33
You really, REALLY do NOT want to try and load this via psql!!!
44

5-
psql:test/temp_load.not_sql:184: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
5+
psql:test/temp_load.not_sql:186: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
66

7-
psql:test/temp_load.not_sql:185: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
7+
psql:test/temp_load.not_sql:187: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
88

99

1010

1111

1212

1313

14-
psql:test/temp_load.not_sql:433: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
14+
psql:test/temp_load.not_sql:435: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
1515

1616

1717

@@ -21,9 +21,9 @@ psql:test/temp_load.not_sql:433: WARNING: I promise you will be sorry if you tr
2121

2222

2323

24-
psql:test/temp_load.not_sql:545: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
24+
psql:test/temp_load.not_sql:547: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
2525

26-
psql:test/temp_load.not_sql:552: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
26+
psql:test/temp_load.not_sql:554: WARNING: I promise you will be sorry if you try to use this as anything other than an extension!
2727

2828

2929

0 commit comments

Comments
 (0)