chore: Bump react dev dep, and move more things to catalog #2707
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Comments (1)
-
packages/react/package.json, line 32-34 (link)logic:
peerDependenciesare too permissive for React 19 upgradeWith React 19 and
@types/react19 in catalog, users with React 16-18 will face peer dependency conflicts. ThepeerDependenciesshould require>=19.0.0to match the new dev dependencies.
7 files reviewed, 1 comment
robbie-c
requested review from
ablaszkiewicz,
daibhin,
hpouillot and
oliverb123
| "target": "ES2018" | ||
| "target": "ES2018", | ||
| "paths": { | ||
| "react": ["./node_modules/@types/react"], |
There was a problem hiding this comment.
Is it needed ? Typescript cannot pick it up automatically ?
robbie-c
deleted the
feat/bump-react-package-and-move-more-things-to-catalog
branch
| "target": "ES2018" | ||
| "target": "ES2018", | ||
| "paths": { | ||
| "react": ["./node_modules/@types/react"], |
There was a problem hiding this comment.
This fixed some bleed of react types elsewhere in the monorepo (react@19) into the react-native package(react@18)
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react' | |||
| import { renderHook } from '@testing-library/react-hooks' | |||
Changes
Let's bump all our deps, starting with react dev deps, as this involves a couple of other fixes to tests.
Note:
Bundled sizewill probably fail as it doesn'tpnpm installbetween versionsRelease info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file