fix(replay): check if recorder needs to be started on opt in #2694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ksvat
force-pushed
the
start-recorder-if-needed-on-opt-in
branch
from
9a83fec to
4cde6a1
Compare
Contributor
Contributor
|
Size Change: +2.83 kB (+0.06%) Total Size: 5.11 MB
ℹ️ View Unchanged
|
ksvat
requested review from
a team,
TueHaulund and
pauldambra
and removed request for
a team
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
pauldambra
reviewed
Dec 5, 2025
| this.consent.optInOut(true) | ||
| this._sync_opt_out_with_persistence() | ||
|
|
||
| // Start queue after opting in |
Member
There was a problem hiding this comment.
[Re: line +3068]
i guess we're calling start twice now in this case
i think it's idempotent but 🙈
See this comment inline on Graphite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
community question pointed out that session recording didnt start after an opt_in() call
this.sessionRecording?.startIfEnabledOrStop()https://posthog.slack.com/archives/C03B04XGLAZ/p1764766008265899
Changes
in
opt_in_capturing(), callstartIfEnabledOrStop()to kick off recording again once opted in.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file