fix(weighted-score): place weight editor after score

Author: mcagnion

spec/System/TestWeightedScore_spec.lua

@@ -386,19 +386,19 @@ describe("WeightedScore — tree integration", function()
 		assert.is_false(called)
 	end)
 
-	it("appendEditWeightsAction inserts an action before WeightedScore", function()
+	it("appendEditWeightsAction appends an action after WeightedScore", function()
 		local list = {
 			{ label = "Sort by Name", sortMode = "name" },
 			{ label = "Sort by Weighted Score", sortMode = "WeightedScore", isWeightedScore = true },
 		}
 		local opened = false
 		WeightedScore.appendEditWeightsAction(list, function() opened = true end)
 		assert.are.equal(3, #list)
-		local entry = list[2]
+		local entry = list[3]
 		assert.is_true(entry.isAction)
 		assert.is_function(entry.action)
 		assert.is_string(entry.label)
-		assert.is_true(list[3].isWeightedScore)
+		assert.is_true(list[2].isWeightedScore)
 		entry.action()
 		assert.is_true(opened, "calling entry.action must invoke the openEditor callback")
 	end)

src/Modules/WeightedScore.lua

@@ -78,12 +78,12 @@ function WeightedScore.computeRatioScore(baseOutput, newOutput, weights)
 	return meanStatDiff
 end
 
--- Insert a contextual "Edit Weights..." action immediately before WeightedScore
--- so the score remains the final metric in every compatible sort dropdown.
+-- Append a contextual "Edit Weights..." action after WeightedScore so the
+-- score remains the final metric while its configuration stays adjacent.
 function WeightedScore.appendEditWeightsAction(sortDropList, openEditor)
-	for index, entry in ipairs(sortDropList) do
+	for _, entry in ipairs(sortDropList) do
 		if entry.isWeightedScore then
-			table.insert(sortDropList, index, {
+			table.insert(sortDropList, {
 				label = colorCodes.TIP .. "Edit Weights...",
 				isAction = true,
 				action = openEditor,