From 6a7f33baa49ca7ac14feff4c20eadaf345eaff38 Mon Sep 17 00:00:00 2001
From: Branimir Rakic <aleatoric@Branimirs-MacBook-Pro.local>
Date: Mon, 1 Jun 2026 19:35:13 +0200
Subject: [PATCH] test(chain): tolerate sendContractTransaction RPC-exhaustion
 wrap in PCA enrich test
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR #883 (`9810bf72`) introduced operator-context wrapping in
`EVMChainAdapter.sendContractTransaction` so that when every configured
RPC endpoint exhausts, the rethrown Error is prefixed with
`"<label> transaction preparation failed on all configured RPC endpoints
(<urls>): <inner>"` and the original error is attached via `cause`.

`evm-adapter-pca-enrich.test.ts` `non-Error / non-custom-error throws
propagate unchanged` was written before that wrap existed and asserted
byte-identical message equality on the rethrown plain Error. With the
wrap in place the assertion fails on every PR targeting `main`,
blocking the entire `Tornado: core + storage + chain` job for #693,
#884, #885, #896, #897, #898, #899 (and any others).

The test's stated invariant — "helper must not swallow or rewrite" —
is about the PCA custom-error enrichment helper, not the transport.
The transport's added context is intentional and the original message
is preserved as a substring (and via `.cause`), so relaxing `toBe` to
`toContain` keeps the spirit while unblocking CI.

Verified locally:

  pnpm exec vitest run packages/chain/test/evm-adapter-pca-enrich.test.ts
  → 3/3 passed

Co-authored-by: Cursor <cursoragent@cursor.com>
---
 packages/chain/test/evm-adapter-pca-enrich.test.ts | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/packages/chain/test/evm-adapter-pca-enrich.test.ts b/packages/chain/test/evm-adapter-pca-enrich.test.ts
index 38a3de1f77..679678ade6 100644
--- a/packages/chain/test/evm-adapter-pca-enrich.test.ts
+++ b/packages/chain/test/evm-adapter-pca-enrich.test.ts
@@ -121,7 +121,12 @@ describe('PCA write methods enrich opaque custom-error reverts on rethrow (codex
   });
 
   it('non-Error / non-custom-error throws propagate unchanged (helper must not swallow or rewrite)', async () => {
-    // (a) plain Error with no revert data — message stays byte-identical.
+    // (a) plain Error with no revert data — the PCA-enrichment helper
+    // must not rewrite or swallow the inner classification. The
+    // transport (`sendContractTransaction`) is allowed to prefix
+    // operator context (RPC endpoint exhaustion) and attach the
+    // original via `.cause`, so we assert the original message is
+    // preserved as a substring rather than byte-identical.
     const plain = adapterWithFakeNft({
       settle: async () => {
         throw new Error('connect ECONNREFUSED 127.0.0.1:8545');
@@ -132,7 +137,7 @@ describe('PCA write methods enrich opaque custom-error reverts on rethrow (codex
       .then(() => null)
       .catch((e) => e as Error);
     expect(e1).toBeInstanceOf(Error);
-    expect(e1!.message).toBe('connect ECONNREFUSED 127.0.0.1:8545');
+    expect(e1!.message).toContain('connect ECONNREFUSED 127.0.0.1:8545');
 
     // (b) non-Error throw (string) — propagated as-is, not wrapped.
     const nonError = adapterWithFakeNft({