Rebrand/v6 header UI changes - #18
Merged
Merged
Conversation
Remove mobile header slot and refactor header to single responsive bar with CSS-based burger menu, add user name and email display, update login/register button labels and ordering, add icon names to menu items, and expand language menu support.
- Create new useAccount hook to centralize account data fetching (avatar, name, email) - Remove duplicate account fetching logic from Header and LearningHeader components - Update LearningHeader to use shared ProfileMenu, LanguageMenu, and MobileNavMenu components - Restructure LearningHeader markup to match site-header pattern with nav-left/nav-right layout - Move learning-header styles to brand package (removed from index.scss) - Add iconName hints to user menu items for consistent icon
… layout - Relocate MobileNavMenu from start to end of nav-left container in both SiteHeader and LearningHeader - Add comment explaining burger menu positioning (display:none siblings below collapse breakpoint) - Extract inline Tibetan font styles to .course-title-tibetan class in LearningHeaderCourseInfo - Add comment referencing brand package styling for course title Tibetan text
…on non-user-triggered releases - Update useReleaseNearFooter to return object with inView and instant flags instead of boolean - Add hasInteractedRef to track whether visitor has scrolled or resized (user interaction) - Set instant:true for all checks until first user interaction to prevent header sliding in on page load - Add ResizeObserver on document body to detect content height changes without scroll/resize - Rename onScroll to scheduleCheck and split out onUserInteraction handler - Apply header-releases-sticky-
- Shorten JSDoc and inline comments across Header, LearningHeader, Menu, and site-header components - Remove verbose explanations of prop threading, hook usage, and component behavior - Consolidate multi-line comments into concise single-line or shorter block comments - Retain essential technical details (e.g. React defaultProps behavior, SSR guards) in abbreviated form - Update test comments to focus on what's being tested rather than implementation rat
- Replace while loop assignment with explicit exec() calls in renderMixedText for clarity - Add early return guard formatting and trailing comma in Tibetan text span - Remove unused courseOrg and courseNumber props from LearningHeaderCourseInfo - Convert LearningHeaderCourseInfo to implicit return arrow function - Update PropTypes to only validate courseTitle instead of full courseInfoDataShape - Replace array index keys with href
The lock file was out of sync with package.json (stale babel transitive dependency versions), which caused npm ci to fail in CI.
10kalden
force-pushed
the
rebrand/v6-header-ui-changes
branch
from
September 7, 2026 10:24
8db4a47 to
bf47728
Compare
Remove unused CaretIcon/FontAwesomeIcon/icon references, fix object-curly-newline destructuring, and add missing trailing newline.
pendingInstant reset to true on every flush, so a later resize-only reading (no scroll/resize event) reported instant again even after the visitor had already scrolled. Track the interaction persistently.
dist/ is listed in .gitignore but was force-committed on the base branch, and its stale dist/__snapshots__/Header.test.jsx.snap made Jest report failure (snapshot.failure) even though every test suite passed, since that snapshot file no longer matches any running test.
This fork has no CODECOV_TOKEN secret configured, so the upload step was failing the whole tests job even though every test passed.
Rebuilt from current src via npm run build so dist matches the new header markup/behavior; the old committed dist was stale and its obsolete snapshot file was making the tests job fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.