From 67876cbc4bf9c1046dcd4bed468e211effa7b2dc Mon Sep 17 00:00:00 2001 From: erkin-io <9297263+erkin-io@users.noreply.github.com> Date: Mon, 16 Nov 2026 21:14:52 +0100 Subject: [PATCH] Keeping query strings out of the HTTP request log Co-Authored-By: Claude Fable 5.2 --- src/server.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/server.c b/src/server.c index c50af083..67f066e7 100644 --- a/src/server.c +++ b/src/server.c @@ -549,15 +549,17 @@ void parse_request(http_request_t *req) { return; } - HAL_INFO("server", "%sNew request: (%s) %s\n" - " Received from: %s%s\n", HAL_COLOR("\x1b[32m"), - req->method, req->uri, client_ip, HAL_COLOR("\x1b[0m")); - if (req->query = strchr(req->uri, '?')) *req->query++ = '\0'; else req->query = NULL; + /* The query can carry passwords and keys, so it is left out of the log */ + HAL_INFO("server", "%sNew request: (%s) %s%s\n" + " Received from: %s%s\n", HAL_COLOR("\x1b[32m"), + req->method, req->uri, req->query ? "?..." : "", + client_ip, HAL_COLOR("\x1b[0m")); + if (req->uri && strstr(req->uri, "..")) { close_socket_fd(req->clntFd); req->clntFd = -1;