Skip to content

Connectors should be consolidated #20

Description

@At11011

Currently, connector.rs as implementations for a mass connector MConnector and an energy connector EConnector. I think we should consolidate these into a single struct. Energy and mass are linked, in the sense that mass itself has inherent energy. Because of this I believe they should be consolidated. The following can change:

  • Instead of two separate connector types with a mass and an energy field, there should be a single connector with both fields. The energy can be calculated on-the-fly using thermodynamics during the simulation. That way, energy can be carried with mass.
  • A special type of connector that supplies unusual forms of energy (such as electrical energy) can be added separately, but it is important for the sake of trustworthy energy balances, for connectors to have both energy and mass as fields that can be tracked.

I believe this will make performing energy balances go by more smoothly as explained in #19 .

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions