Skip to content

Commit e01df02

Browse files
committed
fix for folder name (including Space name) not being included in project completion list in yearly note
1 parent 76b2375 commit e01df02

File tree

6 files changed

+16
-10
lines changed

6 files changed

+16
-10
lines changed

helpers/folders.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ export function getFolderDisplayName(folderPath: string, includeTeamspaceEmoji:
331331
if (!folderPath) {
332332
throw new Error(`Empty folderPath given. Returning '(error)'.`)
333333
}
334-
// logDebug('folders/getFolderDisplayName', `folderPath: ${folderPath}`)
334+
// logDebug('folders/getFolderDisplayName', `Starting for '${folderPath}'`)
335335

336336
if (isTeamspaceNoteFromFilename(folderPath)) {
337337
const teamspaceID = getTeamspaceIDFromFilename(folderPath)
@@ -345,6 +345,7 @@ export function getFolderDisplayName(folderPath: string, includeTeamspaceEmoji:
345345
}
346346
return `[${includeTeamspaceEmoji ? '👥 ' : ''}${teamspaceName}] ${folderPart}`
347347
} else {
348+
// logDebug('folders/getFolderDisplayName', `-> (not Teamspace) '${folderPath}'`)
348349
return folderPath
349350
}
350351
} catch (error) {

jgclark.Reviews/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
# What's changed in 🔬 Projects + Reviews plugin?
22
See [website README for more details](https://github.com/NotePlan/plugins/tree/main/jgclark.Reviews), and how to configure.under-the-hood fixes for integration with Dashboard plugin
33

4-
<!-- - TODO:fix for folder name not being included in project completion list in yearly note -->
4+
## [1.3.0.b11] - 2026-02-14
5+
- fix for folder name (including Space name) not being included in project completion list in yearly note
6+
57
## [1.3.0.b10] - 2026-02-14
68
- Added 'Next' review button to top bar.
79
- Re-wrote finding open project note now there can be multiple Editors open.

jgclark.Reviews/plugin.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"plugin.author": "Jonathan Clark",
1010
"plugin.url": "https://noteplan.com/plugins/jgclark.Reviews",
1111
"plugin.changelog": "https://github.com/NotePlan/plugins/blob/main/jgclark.Reviews/CHANGELOG.md",
12-
"plugin.version": "1.3.0.b10",
12+
"plugin.version": "1.3.0.b11",
1313
"plugin.releaseStatus": "beta",
1414
"plugin.lastUpdateInfo": "1.3.0.b9: New 'Also write most recent Progress line to frontmatter?' option.\n1.3.0.b8: Improved the project dialog box, including new 'Start' button for reviews.\n1.3.0.b7: Improved next action processing. Turned back on automatic updates of Dashboard plugin (if open).\n1.3.0.b6: Small improvements.\n1.3.0.b5: New 'Progress Heading' settings. Fix when using `metadata:` key in frontmatter, and \n1.3.0.b4: 'Start Reviews' bug fix and various layout improvements.\n1.3.0.b3: can now display the first open task/checklist in a project as the 'next action' by adding a new 'Sequential project marker' to the frontmatter (e.g. `project: #sequential`).\n1.3.0.b2: now supports 'show in main window' setting. Other small improvements and fixes.\n1.3.0.b1: now supports projects in (Team)Space notes, using the Perspective setting from Dashboard v2.4 which allows you to specify which (Team)Spaces you wish to include.",
1515
"plugin.script": "script.js",

jgclark.Reviews/src/projectClass.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
//-----------------------------------------------------------------------------
33
// Project class definition for Review plugin
44
// by Jonathan Clark
5-
// Last updated 2026-02-14 for v1.3.0.b9, @jgclark
5+
// Last updated 2026-02-14 for v1.3.0.b10, @jgclark
66
//-----------------------------------------------------------------------------
77

88
// Import Helper functions

jgclark.Reviews/src/projects.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,10 @@ async function reloadAndUpdateLists(note: TNote, config: ReviewConfig, shouldArc
7575
* @private
7676
*/
7777
function addToYearlyNote(thisProject: Project, config: ReviewConfig): void {
78-
const lineToAdd = generateProjectOutputLine(thisProject,
79-
config, 'list') // list = for summary note, without [x] etc.
78+
// Pass config with showFolderName so folder appears before title (config may be frozen from loadJSON)
79+
const lineToAdd = generateProjectOutputLine(thisProject,
80+
{ ...config, showFolderName: true },
81+
'list') // list = for summary note, without [x] etc.
8082
const yearlyNote = DataStore.calendarNoteByDateString(thisYearStr)
8183
if (yearlyNote != null) {
8284
logInfo('addToYearlyNote', `Will add '${lineToAdd}' to note '${yearlyNote.filename}'`)

jgclark.Reviews/src/projectsHTMLGenerator.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -273,14 +273,15 @@ function decoratedProjectTitle(thisProject: Project, style: string, config: any)
273273

274274
case 'list': {
275275
const folderNamePart = config.showFolderName ? getFolderDisplayName(thisProject.folder, true) : ''
276+
const folderPrefix = folderNamePart!=='' ? `${folderNamePart} / ` : ''
276277
if (thisProject.isCompleted) {
277-
return `${folderNamePart}[[${titlePart}]]`
278+
return `${folderPrefix}[[${titlePart}]]`
278279
} else if (thisProject.isCancelled) {
279-
return `~~${folderNamePart}[[${titlePart}]]~~`
280+
return `~~${folderPrefix}[[${titlePart}]]~~`
280281
} else if (thisProject.isPaused) {
281-
return `⏸ **Paused**: ${folderNamePart}[[${titlePart}]]`
282+
return `⏸ **Paused**: ${folderPrefix}[[${titlePart}]]`
282283
} else {
283-
return `${folderNamePart}[[${titlePart}]]` // if this has a [ ] prefix then it of course turns it into a task, which is probably not what we want.
284+
return `${folderPrefix}[[${titlePart}]]` // if this has a [ ] prefix then it of course turns it into a task, which is probably not what we want.
284285
}
285286
}
286287

0 commit comments

Comments
 (0)