b17 tried and failed to get 'Rename Perspective' to actually save it fully to settings.json

Author: jgclark

jgclark.Dashboard/CHANGELOG.md

@@ -8,11 +8,11 @@ For more details see the [plugin's documentation](https://github.com/NotePlan/pl
 - TODO: fix long-standing layout bug where some tooltips were getting clipped
 - TODO: fix isNoteFromAllowedFolder() for teamspace or possibly 2025-W21.md
 -->
-<!-- - ??? dev: check winowID throughout -->
 
 ## [2.4.0.b17] 2026-01-21
 ### New
 - added new way to select items to show from Calendar sections: "Calendar note Sections to Include". There is already a way to exclude specific sections in a calendar note; this adds a way to only include specific sections. The matches are partial, so 'Home' will include 'Home' and 'The Home Areas' etc. If left blank, all sections are still included.
+- WIP: tried and failed to get 'Rename Perspective' to actually save it fully to settings.json
 
 ## [2.4.0.b16] 2026-01-20
 ### Fixes
@@ -24,6 +24,7 @@ For more details see the [plugin's documentation](https://github.com/NotePlan/pl
 - dev: suppress "backup settings" messages to users on upgrades
 - align the two different sidebar icon colours
 - dev: fix a wrong windowID that had crept in
+- dev: check using same winowID throughout
 
 ## [2.4.0.b15] 2026-01-17
 ### Changed

jgclark.Dashboard/src/dashboardSettings.js

@@ -110,7 +110,7 @@ export const dashboardSettingDefs: Array<TSettingItem> = [
     description:
       "Comma-separated list of folder(s) to ignore when selecting open tasks/checklists to show. The matches are partial, so 'Work' will exclude 'Work' and 'Work/CompanyA' etc. To ignore notes at the top-level (not in a folder), include '/' in the list. (@Trash is always ignored, but other special folders need to be specified, e.g. @Archive, @Templates.)",
     type: 'input',
-    default: '@Archive, @Templates, Saved Searches',
+    default: '@Archive, @Templates, @Searches, @WindowSets',
     compactDisplay: true,
   },
   {

jgclark.Dashboard/src/perspectiveClickHandlers.js

@@ -3,7 +3,7 @@
 // clickHandlers.js
 // Handler functions for dashboard clicks that come over the bridge
 // The routing is in pluginToHTMLBridge.js/bridgeClickDashboardItem()
-// Last updated 2025-06-04 for v2.3.0
+// Last updated 2026-01-22 for v2.4.0.b17
 //-----------------------------------------------------------------------------
 
 import { getDashboardSettings, handlerResult, setPluginData, getDashboardSettingsDefaults } from './dashboardHelpers'
@@ -27,23 +27,25 @@ import {
 import { clo, dt, JSP, logDebug, logError, logInfo, logTimer, logWarn } from '@helpers/dev'
 import { getSettings, saveSettings } from '@helpers/NPConfiguration'
 
-/****************************************************************************************************************************
- *                             NOTES
- ****************************************************************************************************************************
-
+/**
+ * -----------------------------------------------------------------------------
+*  Notes
+* -------------------------------------------------------------------------------
 - Handlers should use the standard return type of TBridgeClickHandlerResult
 - handlerResult() can be used to create the result object
 - Types are defined in types.js
     - type TActionOnReturn = 'UPDATE_CONTENT' | 'REMOVE_LINE' | 'REFRESH_JSON' | 'START_DELAYED_REFRESH_TIMER' etc.
+*/
 
-/****************************************************************************************************************************
- *                             Data types + constants
- ****************************************************************************************************************************/
+//-----------------------------------------------------------------------------
+// Constants
+//-----------------------------------------------------------------------------
 
 const pluginID = 'jgclark.Dashboard'
-/****************************************************************************************************************************
- *                             HANDLERS
- ****************************************************************************************************************************/
+
+//-----------------------------------------------------------------------------
+// Handlers
+//-----------------------------------------------------------------------------
 
 export async function doAddNewPerspective(_data: MessageDataObject): Promise<TBridgeClickHandlerResult> {
   clo(_data, `doAddNewPerspective starting ...`)
@@ -115,12 +117,25 @@ export async function doRenamePerspective(data: MessageDataObject): Promise<TBri
   if (newName === '') return handlerResult(false, [], { errorMsg: `doRenamePerspective: newName is empty` })
   if (origName === '-') return handlerResult(false, [], { errorMsg: `Perspective "-" cannot be renamed` })
   if (newName === '-') return handlerResult(false, [], { errorMsg: `Perspectives cannot be renamed to "-".` })
+  const dashboardSettings = await getDashboardSettings()
   const perspectiveSettings = await getPerspectiveSettings()
   const existingDef = getPerspectiveNamed(origName, perspectiveSettings)
-  if (!existingDef) return handlerResult(false, [], { errorMsg: `can't get definition for perspective ${origName}` })
+  if (!existingDef) return handlerResult(false, [], { errorMsg: `Can't find the definition for perspective "${origName}"` })
   const revisedDefs = renamePerspective(origName, newName, perspectiveSettings)
-  if (!revisedDefs) return handlerResult(false, [], { errorMsg: `savePerspectiveSettings failed` })
-  const res = await savePerspectiveSettings(revisedDefs)
+  if (!revisedDefs) return handlerResult(false, [], { errorMsg: `renamePerspective failed` })
+
+  // v1
+  // const res = await savePerspectiveSettings(revisedDefs)
+  // if (!res) {
+  //   return handlerResult(false, [], { errorMsg: `saveSettings failed` })
+  // }
+  // v2. But still not saving the dashboardSettings.
+  const res = await saveSettings(pluginID, {
+    ...(await getSettings('jgclark.Dashboard')),
+    dashboardSettings: dashboardSettings,
+    perspectiveSettings: revisedDefs,
+  })
+
   await setPluginData({ perspectiveSettings: revisedDefs }, `_Saved perspective ${newName}`)
   if (!res) {
     return handlerResult(false, [], { errorMsg: `savePerspectiveSettings failed` })

jgclark.Dashboard/src/perspectiveHelpers.js

@@ -2,7 +2,7 @@
 // @flow
 //-----------------------------------------------------------------------------
 // Dashboard plugin helper functions for Perspectives
-// Last updated 2025-12-01 for v2.3.1
+// Last updated 2026-01-22 for v2.4.0.b17, @jgclark
 //-----------------------------------------------------------------------------
 
 import pluginJson from '../plugin.json'
@@ -287,28 +287,38 @@ export function replacePerspectiveDef(perspectiveSettings: Array<TPerspectiveDef
  * Set the isActive flag for the perspective with the given name (and false for all others) & reset isModified flag on all
  * @param {string} name
  * @param {Array<TPerspectiveDef>} perspectiveSettings
- * @returns {Array<TPerspectiveDef>}
+ * @returns {Array<TPerspectiveDef>} the revised perspectiveSettings array
  */
 export function setActivePerspective(name: string, perspectiveSettings: Array<TPerspectiveDef>): Array<TPerspectiveDef> {
   // map over perspectiveSettings, setting isActive to true for the one with name === name, and false for all others
-  return perspectiveSettings ? perspectiveSettings.map((s) => ({ ...s, isActive: s.name === name, isModified: false })) : []
+  return perspectiveSettings ? perspectiveSettings.map((s) => ({
+    ...s,
+    isActive: s.name === name,
+    isModified: false,
+  })) : []
 }
 
 /**
- * Set the isActive flag for the perspective with the given name (and false for all others) & reset isModified flag on all
- * @param {string} name
+ * Set the isActive flag for the perspective with the given name (and false for all others) & reset isModified flag on all. The isModified flag is only reset for the renamed perspective.
+ * @param {string} oldName
+ * @param {string} newName - the new name for the perspective
  * @param {Array<TPerspectiveDef>} perspectiveSettings
- * @returns {Array<TPerspectiveDef>}
+ * @returns {Array<TPerspectiveDef>} the revised perspectiveSettings array
  */
 export function renamePerspective(oldName: string, newName: string, perspectiveSettings: Array<TPerspectiveDef>): Array<TPerspectiveDef> {
-  return perspectiveSettings.map((s) => ({ ...s, name: s.name === oldName ? newName : s.name }))
+  return perspectiveSettings.map((s) => (
+    {
+      ...s,
+      name: s.name === oldName ? newName : s.name,
+      isModified: s.name === oldName ? false : s.isModified  // Reset isModified for renamed perspective
+    }))
 }
 
 /**
  * Private function to add a new Perspective definition to the array
  * @param {Array<TPerspectiveDef>} perspectiveSettings
  * @param {TPerspectiveDef} newDef
- * @returns {Array<TPerspectiveDef>}
+ * @returns {Array<TPerspectiveDef>} the revised perspectiveSettings array
  */
 function addPerspectiveDef(perspectiveSettings: Array<TPerspectiveDef>, newDef: TPerspectiveDef): Array<TPerspectiveDef> {
   return [...perspectiveSettings, newDef]
@@ -318,7 +328,7 @@ function addPerspectiveDef(perspectiveSettings: Array<TPerspectiveDef>, newDef:
  * Private function to delete a Perspective definition from the array
  * @param {Array<TPerspectiveDef>} perspectiveSettings
  * @param {string} name
- * @returns {Array<TPerspectiveDef>}
+ * @returns {Array<TPerspectiveDef>} the revised perspectiveSettings array
  */
 function deletePerspectiveDef(perspectiveSettings: Array<TPerspectiveDef>, name: string): Array<TPerspectiveDef> {
   return perspectiveSettings.filter((s) => s.name !== name)
@@ -726,17 +736,6 @@ export async function addNewPerspective(nameArg?: string): Promise<void> {
  */
 export async function deleteAllNamedPerspectiveSettings(): Promise<void> {
   logDebug('deleteAllNamedPerspectiveSettings', `Attempting to delete all Perspective settings (other than default) ...`)
-  // v1
-  // const pluginSettings = DataStore.settings
-  // pluginSettings.perspectiveSettings = "[]"
-  // const dSettings = await getDashboardSettings()
-  // $FlowIgnore
-  // delete dSettings.perspectiveSettings
-  // pluginSettings.dashboardSettings = JSON.stringify(dSettings)
-  // clo(pluginSettings.perspectiveSettings, `... leaves: pluginSettings.perspectiveSettings =`)
-  // DataStore.settings = pluginSettings
-
-  // V2
   let allDefs = await getPerspectiveSettings()
   for (const p of allDefs) {
     if (p.name !== '-') {
@@ -745,15 +744,16 @@ export async function deleteAllNamedPerspectiveSettings(): Promise<void> {
   }
   logDebug('deleteAllNamedPerspectiveSettings', `Deleted all named perspectives, other than default.`)
 
-  allDefs = await getPerspectiveSettings()
-  const updatedListOfPerspectives = getDisplayListOfPerspectiveNames(allDefs)
+  const onlyDefaultPerspectiveDef: Array<TPerspectiveDef> = await getPerspectiveSettings()
+  const updatedListOfPerspectives = getDisplayListOfPerspectiveNames(onlyDefaultPerspectiveDef)
   logDebug('deleteAllNamedPerspectiveSettings', `New default list of available perspectives: [${String(updatedListOfPerspectives ?? [])}]`)
 
   // Set current perspective to default ("-")
-  const newPerspectiveSettings = await switchToPerspective('-', allDefs)
+  const newPerspectiveSettings = await switchToPerspective('-', onlyDefaultPerspectiveDef)
   await setPluginData({ perspectiveSettings: newPerspectiveSettings }, `_Deleted all named perspectives`)
 
-  // TODO: Update tagCache definition list json
+  // Update tagCache definition list json
+  updateTagMentionCacheDefinitionsFromAllPerspectives(onlyDefaultPerspectiveDef)
   logDebug('deleteAllNamedPerspectiveSettings', `Result of switchToPerspective("-"): ${String(newPerspectiveSettings)}`)
 }