Skip to content

python313Packages.debugpy: make src reproducible #468328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aleksanaa merged 2 commits into from
Dec 6, 2025
Merged

python313Packages.debugpy: make src reproducible #468328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ef5f46
python313Packages.debugpy: make src reproducible
kira-bruneau Dec 6, 2025
a245797
python313Packages.debugpy: remove hardcode-version patch
kira-bruneau Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions pkgs/development/python-modules/debugpy/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,20 @@ buildPythonPackage rec {
owner = "microsoft";
repo = "debugpy";
tag = "v${version}";

# Upstream uses .gitattributes to inject information about the revision
# hash and the refname into `src/debugpy/_version.py`, see:
#
# - https://git-scm.com/docs/gitattributes#_export_subst and
# - https://github.com/microsoft/debugpy/blob/v1.8.17/src/debugpy/_version.py#L24-L30
postFetch = ''
sed -i 's/git_refnames = "[^"]*"/git_refnames = " (tag: ${src.tag})"/' "$out/src/debugpy/_version.py"
'';

hash = "sha256-eAiCtSJUqLASapxnYCyq1UCiGz6QmKQum7Vs3MoU1s8=";
Copy link
Member

@Aleksanaa Aleksanaa Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried that the hash didn't change?

Copy link
Contributor Author

@kira-bruneau kira-bruneau Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the original commit of this PR: 07a17bc didn't include the fix from #468283

};

patches = [
# Use nixpkgs version instead of versioneer
(replaceVars ./hardcode-version.patch {
Copy link
Contributor Author

@kira-bruneau kira-bruneau Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer necessary since microsoft/debugpy#866

inherit version;
})

# Fix importing debugpy in:
# - test_nodebug[module-launch(externalTerminal)]
# - test_nodebug[module-launch(integratedTerminal)]
Expand Down
47 changes: 0 additions & 47 deletions pkgs/development/python-modules/debugpy/hardcode-version.patch
View file
Open in desktop

This file was deleted.

Loading